[PR #1302] [MERGED] fix(music): fix seek bar interaction and freezing in popup #5505

New issue

Closed

opened 2026-05-23 00:57:24 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 00:57:24 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1302
Author: @postsolar
Created: 12/25/2025
Status: ✅ Merged
Merged: 12/26/2025
Merged by: @JakeStanger

Base: master ← Head: fix/mpris-seek

📝 Commits (1)

3cf04a0 fix(music): fix seek bar interaction and freezing in popup

📊 Changes

1 file changed (+11 additions, -29 deletions)

View changed files

📝 src/modules/music/mod.rs (+11 -29)

📄 Description

Closes #1300

Replace incorrect GestureClick pattern with proper GTK4 Scale handling:

Use connect_value_changed instead of manual gesture handlers
Check has_css_class("dragging") instead of manual drag_lock (note: same as Volume module does)
Only update progress when not dragging to prevent conflicts

This fixes two issues:

Seeking now works for both clicking and dragging
Progress bar and duration labels no longer freeze after seeking

The previous implementation used a manual AtomicBool lock that could get stuck, causing the UI to freeze. GTK4 automatically manages the "dragging" CSS class, making manual gesture handling unnecessary.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1302 **Author:** [@postsolar](https://github.com/postsolar) **Created:** 12/25/2025 **Status:** ✅ Merged **Merged:** 12/26/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/mpris-seek` --- ### 📝 Commits (1) - [`3cf04a0`](https://github.com/JakeStanger/ironbar/commit/3cf04a0f6d2191029a133c493d55b87df6b2f5c3) fix(music): fix seek bar interaction and freezing in popup ### 📊 Changes **1 file changed** (+11 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/music/mod.rs` (+11 -29) </details> ### 📄 Description Closes #1300 --- Replace incorrect GestureClick pattern with proper GTK4 Scale handling: - Use connect_value_changed instead of manual gesture handlers - Check has_css_class("dragging") instead of manual drag_lock _(note: same as Volume module does)_ - Only update progress when not dragging to prevent conflicts This fixes two issues: 1. Seeking now works for both clicking and dragging 2. Progress bar and duration labels no longer freeze after seeking The previous implementation used a manual AtomicBool lock that could get stuck, causing the UI to freeze. GTK4 automatically manages the "dragging" CSS class, making manual gesture handling unnecessary. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 00:57:24 +01:00