[PR #1284] [MERGED] feat: music marquee #5496

Closed
opened 2026-05-23 00:57:23 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1284
Author: @postsolar
Created: 12/18/2025
Status: Merged
Merged: 12/21/2025
Merged by: @JakeStanger

Base: masterHead: feat/music-marquee


📝 Commits (5)

  • c6e4b93 refactor: extract more of marquee code from volume mod
  • 1988293 feat(music): add marquee effect for bar widget and popup track title labels
  • 5e7293d feat(music): extend marquee mode to popup artist and album
  • 93dec8e readability improv
  • a47d064 readability improv #2

📊 Changes

6 files changed (+352 additions, -226 deletions)

View changed files

📝 docs/modules/Music.md (+31 -1)
📝 src/gtk_helpers.rs (+196 -124)
📝 src/image/gtk.rs (+36 -15)
📝 src/modules/music/config.rs (+21 -1)
📝 src/modules/music/mod.rs (+55 -46)
📝 src/modules/volume.rs (+13 -39)

📄 Description

Works the same as #1250 just moves around its code a bit and makes music module use it, too.

One question I'm not sure about is whether for icon-prefixed labels we want the icon to scroll as well. Currently it doesn't.

Closes #1011


I think from here it would be relatively easy to extend it to just about any module, but I chose to move slower so as to:

  • Collect user feedback over a few weeks maybe
  • Consider design questions

E.g. music is obvious for my use case, and, say, Label or Script are obvious because they are meant to be as flexible as it gets, but outside of these it's not immediately apparent to me what should or should not be done :)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1284 **Author:** [@postsolar](https://github.com/postsolar) **Created:** 12/18/2025 **Status:** ✅ Merged **Merged:** 12/21/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `feat/music-marquee` --- ### 📝 Commits (5) - [`c6e4b93`](https://github.com/JakeStanger/ironbar/commit/c6e4b9313121456d5954a5409ca1f1dab4dabc91) refactor: extract more of marquee code from volume mod - [`1988293`](https://github.com/JakeStanger/ironbar/commit/19882932956727b074573edde998ecee7eb2bb09) feat(music): add marquee effect for bar widget and popup track title labels - [`5e7293d`](https://github.com/JakeStanger/ironbar/commit/5e7293d2a72ae1b9c720974f338b1113e987e10b) feat(music): extend marquee mode to popup artist and album - [`93dec8e`](https://github.com/JakeStanger/ironbar/commit/93dec8ef1dc398f45aef60223bb37ed15992bf33) readability improv - [`a47d064`](https://github.com/JakeStanger/ironbar/commit/a47d0643f6b737a7f3f7699845c1928b35122fa7) readability improv #2 ### 📊 Changes **6 files changed** (+352 additions, -226 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/Music.md` (+31 -1) 📝 `src/gtk_helpers.rs` (+196 -124) 📝 `src/image/gtk.rs` (+36 -15) 📝 `src/modules/music/config.rs` (+21 -1) 📝 `src/modules/music/mod.rs` (+55 -46) 📝 `src/modules/volume.rs` (+13 -39) </details> ### 📄 Description Works the same as #1250 just moves around its code a bit and makes music module use it, too. One question I'm not sure about is whether for icon-prefixed labels we want the icon to scroll as well. Currently it doesn't. Closes #1011 --- I think from here it would be relatively easy to extend it to just about any module, but I chose to move slower so as to: - Collect user feedback over a few weeks maybe - Consider design questions E.g. music is obvious for my use case, and, say, Label or Script are obvious because they are meant to be as flexible as it gets, but outside of these it's not immediately apparent to me what should or should not be done :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-23 00:57:23 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#5496
No description provided.