mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 06:15:21 +01:00
[PR #1284] [MERGED] feat: music marquee #5496
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#5496
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/1284
Author: @postsolar
Created: 12/18/2025
Status: ✅ Merged
Merged: 12/21/2025
Merged by: @JakeStanger
Base:
master← Head:feat/music-marquee📝 Commits (5)
c6e4b93refactor: extract more of marquee code from volume mod1988293feat(music): add marquee effect for bar widget and popup track title labels5e7293dfeat(music): extend marquee mode to popup artist and album93dec8ereadability improva47d064readability improv #2📊 Changes
6 files changed (+352 additions, -226 deletions)
View changed files
📝
docs/modules/Music.md(+31 -1)📝
src/gtk_helpers.rs(+196 -124)📝
src/image/gtk.rs(+36 -15)📝
src/modules/music/config.rs(+21 -1)📝
src/modules/music/mod.rs(+55 -46)📝
src/modules/volume.rs(+13 -39)📄 Description
Works the same as #1250 just moves around its code a bit and makes music module use it, too.
One question I'm not sure about is whether for icon-prefixed labels we want the icon to scroll as well. Currently it doesn't.
Closes #1011
I think from here it would be relatively easy to extend it to just about any module, but I chose to move slower so as to:
E.g. music is obvious for my use case, and, say, Label or Script are obvious because they are meant to be as flexible as it gets, but outside of these it's not immediately apparent to me what should or should not be done :)
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.