mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 09:15:22 +01:00
[PR #206] [MERGED] Music progress/seek bar #549
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#549
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/206
Author: @JakeStanger
Created: 6/30/2023
Status: ✅ Merged
Merged: 6/30/2023
Merged by: @JakeStanger
Base:
master← Head:feat/music-progress📝 Commits (2)
12053f1feat(music): progress/seek bar in popup1759945fix(music): correctly show/hide popup elements based on player capabilities📊 Changes
5 files changed (+323 additions, -124 deletions)
View changed files
📝
docs/modules/Music.md(+5 -4)📝
src/clients/music/mod.rs(+18 -5)📝
src/clients/music/mpd.rs(+49 -16)📝
src/clients/music/mpris.rs(+82 -22)📝
src/modules/music/mod.rs(+169 -77)📄 Description
Resolves #128.
Also includes a fix to ensure elements in the popup are hidden if the connected player is not capable of providing the info.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.