[PR #1241] [MERGED] fix(image): symbolic icons not rendering in GTK 4.20+ #5466

Closed
opened 2026-05-23 00:57:17 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1241
Author: @slowsage
Created: 11/19/2025
Status: Merged
Merged: 12/17/2025
Merged by: @JakeStanger

Base: masterHead: symbolic


📝 Commits (1)

  • 99e3e40 fix(image): symbolic icons not rendering in GTK 4.20+

📊 Changes

2 files changed (+127 additions, -111 deletions)

View changed files

📝 src/image/gtk.rs (+106 -85)
📝 src/image/provider.rs (+21 -26)

📄 Description

For symbolic icons to work with ironbar's icon_theme, we need to adapt to GTK 4.20 changes.

Required more refactoring than intended to

  1. keep the Image vs Picture check localized
  2. handle both sync (Image) and async (Picture).

Also removed duplicate feature = "clipboard",.

Relevant:
https://docs.gtk.org/gtk4/migrating-3to4.html#adapt-to-gtkicontheme-api-changes
https://docs.gtk.org/gtk4/migrating-3to4.html#dont-use-gtk-icon-theme-in-your-css

Fixes: #1039

Given the scope, prolly makes sense for v0.19.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1241 **Author:** [@slowsage](https://github.com/slowsage) **Created:** 11/19/2025 **Status:** ✅ Merged **Merged:** 12/17/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `symbolic` --- ### 📝 Commits (1) - [`99e3e40`](https://github.com/JakeStanger/ironbar/commit/99e3e40bd96bf8524bb13d00a914667b75d733fa) fix(image): symbolic icons not rendering in GTK 4.20+ ### 📊 Changes **2 files changed** (+127 additions, -111 deletions) <details> <summary>View changed files</summary> 📝 `src/image/gtk.rs` (+106 -85) 📝 `src/image/provider.rs` (+21 -26) </details> ### 📄 Description For symbolic icons to work with ironbar's `icon_theme`, we need to adapt to GTK 4.20 [changes](https://docs.gtk.org/gtk4/migrating-3to4.html#adapt-to-gtkicontheme-api-changes). Required more refactoring than intended to 1. keep the Image vs Picture check localized 3. handle both sync (Image) and async (Picture). Also removed duplicate `feature = "clipboard",`. Relevant: https://docs.gtk.org/gtk4/migrating-3to4.html#adapt-to-gtkicontheme-api-changes https://docs.gtk.org/gtk4/migrating-3to4.html#dont-use-gtk-icon-theme-in-your-css Fixes: #1039 Given the scope, prolly makes sense for v0.19. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-23 00:57:17 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#5466
No description provided.