[PR #189] [MERGED] fix: add sensible class names for icon labels #537

New issue

Closed

opened 2026-05-22 21:53:49 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 21:53:49 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/189
Author: @JakeStanger
Created: 6/12/2023
Status: ✅ Merged
Merged: 6/14/2023
Merged by: @JakeStanger

Base: master ← Head: fix/icon-classes

📝 Commits (3)

cbba2bc build: update deps, temporarily pin hyprland
e11177f fix: add sensible class names for icon labels
96d36c4 docs: add missing icon/image selectors

📊 Changes

7 files changed (+285 additions, -343 deletions)

View changed files

📝 Cargo.lock (+233 -312)
📝 Cargo.toml (+1 -1)
📝 docs/modules/Clipboard.md (+3 -0)
📝 docs/modules/Music.md (+35 -23)
📝 docs/modules/Workspaces.md (+8 -5)
📝 src/image/gtk.rs (+4 -1)
📝 src/modules/music/mod.rs (+1 -1)

📄 Description

BREAKING CHANGE: Where both textual and image icons are supported, CSS classes have changed to better reflect their targets. .icon has changed to .icon-box and .icon now targets the underlying element. .label has been changed to .icon.text-icon. This affects icons on the music, workspaces, and clipboard modules.

Resolves #185.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/189 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 6/12/2023 **Status:** ✅ Merged **Merged:** 6/14/2023 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/icon-classes` --- ### 📝 Commits (3) - [`cbba2bc`](https://github.com/JakeStanger/ironbar/commit/cbba2bc614a1d1d87b24b7b52acad88c61b8888b) build: update deps, temporarily pin hyprland - [`e11177f`](https://github.com/JakeStanger/ironbar/commit/e11177fea3095560057278d71cebca01bed295d6) fix: add sensible class names for icon labels - [`96d36c4`](https://github.com/JakeStanger/ironbar/commit/96d36c43d43ba2f9e9d9441ae01c0743cc56f627) docs: add missing icon/image selectors ### 📊 Changes **7 files changed** (+285 additions, -343 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+233 -312) 📝 `Cargo.toml` (+1 -1) 📝 `docs/modules/Clipboard.md` (+3 -0) 📝 `docs/modules/Music.md` (+35 -23) 📝 `docs/modules/Workspaces.md` (+8 -5) 📝 `src/image/gtk.rs` (+4 -1) 📝 `src/modules/music/mod.rs` (+1 -1) </details> ### 📄 Description BREAKING CHANGE: Where both textual and image icons are supported, CSS classes have changed to better reflect their targets. `.icon` has changed to `.icon-box` and `.icon` now targets the underlying element. `.label` has been changed to `.icon.text-icon`. This affects icons on the **music**, **workspaces**, and **clipboard** modules. Resolves #185. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 21:53:49 +01:00