mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 10:15:20 +01:00
[PR #1004] [CLOSED] feat(keyboard): implement labels with icons #5305
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#5305
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/1004
Author: @tobias47n9e
Created: 5/25/2025
Status: ❌ Closed
Base:
master← Head:feat/keyboard-indicator-labels📝 Commits (1)
0c4b05cfeat(keyboard): implement labels with icons📊 Changes
1 file changed (+65 additions, -1 deletions)
View changed files
📝
src/modules/keyboard.rs(+65 -1)📄 Description
I would like to build a purely text-based layout in the bar and was unable to configure the keyboard indicators to just use a
formatstring similar to some of the other widgets that I have tried. I put a patch together, but it makes the code and config a bit repetitive (see caps-lock config below).Would a patch like this be acceptable? I could put in some more time to clean it up. Or would it be better to split the keyboard indicators into 3 widgets (caps-lock, num-lock and layout)?
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.