[PR #999] [MERGED] fix(clock): reset selected calendar date on each popup open #5303

New issue

Closed

opened 2026-05-23 00:56:51 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 00:56:51 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/999
Author: @postsolar
Created: 5/20/2025
Status: ✅ Merged
Merged: 5/20/2025
Merged by: @JakeStanger

Base: master ← Head: fix-calendar-date

📝 Commits (1)

c4b29e1 Calendar: reset selected date on each popup open

📊 Changes

1 file changed (+8 additions, -1 deletions)

View changed files

📝 src/modules/clock.rs (+8 -1)

📄 Description

Closes #931
Additional context #931

So I chose to go with using selections. I think markings have a few cons:

Would need to somehow style it because by default it's just bold text, much less noticeable than selections. I checked adw-gtk3 and couldn't find a selector for the marked day.
Would need to also hook into connect_{next,prev}_{month,year} to unmark currently marked day, because marks persist across month/year changes (only a day is marked, and not a date).
Would still need to do something with selections, because them being there without user having actually selected anything might be confusing. E.g. boot PC on Monday, open calendar on Wednesday, Monday is selected for some reason.

All in all it's a lot less code and problems with selections and there's currently hardly a non-contrived use case for them so I think changing their semantics is fine.

I'm not sure if it's needed to also reset the date at midnight. It's hard to imagine a scenario where it's either a significant win or a significant loss for UX.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/999 **Author:** [@postsolar](https://github.com/postsolar) **Created:** 5/20/2025 **Status:** ✅ Merged **Merged:** 5/20/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix-calendar-date` --- ### 📝 Commits (1) - [`c4b29e1`](https://github.com/JakeStanger/ironbar/commit/c4b29e199c24226b294c6878bfbb7ec7e0287f66) Calendar: reset selected date on each popup open ### 📊 Changes **1 file changed** (+8 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/clock.rs` (+8 -1) </details> ### 📄 Description Closes #931 Additional context #931 So I chose to go with using selections. I think markings have a few cons: - Would need to somehow style it because by default it's just bold text, much less noticeable than selections. I checked [adw-gtk3](https://github.com/lassekongo83/adw-gtk3) and couldn't find a selector for the marked day. - Would need to also hook into `connect_{next,prev}_{month,year}` to unmark currently marked day, because marks persist across month/year changes (only a *day* is marked, and not a *date*). - Would still need to do something with selections, because them being there without user having actually selected anything might be confusing. E.g. boot PC on Monday, open calendar on Wednesday, Monday is selected for some reason. All in all it's a lot less code and problems with selections and there's currently hardly a non-contrived use case for them so I think changing their semantics is fine. I'm not sure if it's needed to also reset the date at midnight. It's hard to imagine a scenario where it's either a significant win or a significant loss for UX. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 00:56:51 +01:00