mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 07:15:19 +01:00
[PR #953] [MERGED] feat(nix)!: standardize home-manager options & restructure flake #5276
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#5276
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/953
Author: @74k1
Created: 5/1/2025
Status: ✅ Merged
Merged: 5/6/2025
Merged by: @JakeStanger
Base:
master← Head:update-flake📝 Commits (4)
5affad3refactor(nix): useflake-partsandflake-compat322fc0cfeat(nix)!: standardize home-manager module optionsd97d07echore(nix): reformatpackage.nixwithalejandra89073dcfeat(nix): uselib.filesetforsrc📊 Changes
8 files changed (+465 additions, -352 deletions)
View changed files
📝
README.md(+29 -2)📝
flake.lock(+50 -0)📝
flake.nix(+94 -183)➖
nix/default.nix(+0 -144)➕
nix/devshell.nix(+25 -0)➕
nix/module.nix(+88 -0)➕
nix/package.nix(+166 -0)📝
shell.nix(+13 -23)📄 Description
This is a draft PR, since I haven't gotten around restructuring the flake into modules. - Once that's done, I'll edit this message.
For now, changes include:
onChange(simpleironbar reloadcommand) forxdg.ConfigFile."ironbar/config.json"config.wayland.systemd.targetinstead of"graphical-session.target"toPartOfandInstall.WantedByPartOfandInstall.WantedByExecReloadcommandExecPostifcfg.style != ""for loading css on service startBREAKING CHANGE:
programs.ironbar.systemdis no longer enabled by default(opinionated) reasons for this breaking change being:
programsshould not have a service enabled by default. For those cases, home-manager hasserviceoptions too.${lib.getExe pkgs.ironbar}to their own Window Manager (for niri:spawn-at-startup, for hyprland:exec-once) to get ironbar running. - and therefore would just want/need theprograms.ironbaroption to configure ironbar.I'm mainly basing this off of
waybar's home-manager options.closes: #950
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.