[PR #890] [CLOSED] Fixed volume module inability to rotate based on bar location #5237

New issue

Closed

opened 2026-05-23 00:56:41 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 00:56:41 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/890
Author: @skelitheprogrammer
Created: 3/10/2025
Status: ❌ Closed

Base: master ← Head: fix/volume-layout

📝 Commits (1)

22400fa added ModuleOrientation to fix volume module orientation

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 src/modules/volume.rs (+5 -2)

📄 Description

Made a discussion #887 which show this problem.

This change based on clock module

Tested horizontal and vertical, all good.
There is still a problem with the behavior of the text and the icon. Currently the icon is not trying to center itself. I can try to fix this in the this PR, but this is my first time using rust so don't at me xD.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/890 **Author:** [@skelitheprogrammer](https://github.com/skelitheprogrammer) **Created:** 3/10/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/volume-layout` --- ### 📝 Commits (1) - [`22400fa`](https://github.com/JakeStanger/ironbar/commit/22400fa506c2aa2b1cd8fa5cee461f03ea3a0d76) added ModuleOrientation to fix volume module orientation ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/volume.rs` (+5 -2) </details> ### 📄 Description Made a discussion #887 which show this problem. This change based on [clock module](https://github.com/JakeStanger/ironbar/blob/master/src/modules/clock.rs#L132) Tested horizontal and vertical, all good. There is still a problem with the behavior of the text and the icon. Currently the icon is not trying to center itself. I can try to fix this in the this PR, but this is my first time using rust so don't at me xD. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 00:56:41 +01:00