mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 09:15:22 +01:00
[PR #837] [MERGED] feat: icon overrides #5199
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#5199
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/837
Author: @BowDown097
Created: 1/11/2025
Status: ✅ Merged
Merged: 2/15/2025
Merged by: @JakeStanger
Base:
master← Head:master📝 Commits (6)
87c6801feat(launcher): icon overridesd1b4af4refactor: make icon overrides bar-level and apply to focused module40d449erefactor: address requested changesd5e4e08refactor: address requested changes (2)2fd49e0refactor: address requested changes (3)c2beda8refactor: ensure one copy of icon_overrides📊 Changes
9 files changed (+77 additions, -18 deletions)
View changed files
📝
docs/Configuration guide.md(+6 -5)📝
docs/modules/Launcher.md(+1 -1)📝
src/bar.rs(+15 -1)📝
src/config/mod.rs(+7 -0)📝
src/main.rs(+4 -0)📝
src/modules/focused.rs(+9 -4)📝
src/modules/launcher/item.rs(+12 -2)📝
src/modules/launcher/mod.rs(+21 -5)📝
src/modules/mod.rs(+2 -0)📄 Description
This allows the user to override an app's icon in the launcher with a specified icon name. The only alternative to this currently is to dig through your icon theme's folder and replace existing entries / manually add entries yourself, which is rather inconvenient.
I thought about instead adding functionality to look for an associated desktop file and use the icon from that if one is found, but I'm not sure how I would address the problem of app IDs not having to match the desktop file name, or anything in the file.
Example:
Before After
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.