[PR #823] [MERGED] refactor: replace channel macros with ext trait methods #5188

New issue

Closed

opened 2026-05-23 00:56:32 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 00:56:32 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/823
Author: @JakeStanger
Created: 12/28/2024
Status: ✅ Merged
Merged: 5/18/2025
Merged by: @JakeStanger

Base: master ← Head: refactor/remove-macros

📝 Commits (1)

f929aef refactor: replace channel macros with ext trait methods

📊 Changes

50 files changed (+657 additions, -475 deletions)

View changed files

➕ src/channels.rs (+155 -0)
📝 src/clients/clipboard.rs (+10 -8)
📝 src/clients/compositor/hyprland.rs (+31 -42)
📝 src/clients/compositor/niri/mod.rs (+3 -2)
📝 src/clients/compositor/sway.rs (+11 -13)
📝 src/clients/libinput.rs (+4 -3)
📝 src/clients/music/mpd.rs (+4 -3)
📝 src/clients/music/mpris.rs (+8 -5)
📝 src/clients/swaync/mod.rs (+3 -2)
📝 src/clients/volume/mod.rs (+3 -2)
📝 src/clients/volume/sink.rs (+6 -5)
📝 src/clients/volume/sink_input.rs (+6 -5)
📝 src/clients/wayland/mod.rs (+15 -12)
📝 src/clients/wayland/wl_output.rs (+13 -22)
📝 src/clients/wayland/wlr_data_control/mod.rs (+9 -10)
📝 src/clients/wayland/wlr_foreign_toplevel/mod.rs (+7 -4)
📝 src/dynamic_value/dynamic_bool.rs (+8 -7)
📝 src/dynamic_value/dynamic_string.rs (+7 -6)
📝 src/image/provider.rs (+5 -5)
📝 src/ipc/server/mod.rs (+6 -6)

...and 30 more files

📄 Description

Big refactor. Replaces all the macros related to channels (send/receive) with traits and extension methods, which is a little bit cleaner and should give the tooling a better shot.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/823 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 12/28/2024 **Status:** ✅ Merged **Merged:** 5/18/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `refactor/remove-macros` --- ### 📝 Commits (1) - [`f929aef`](https://github.com/JakeStanger/ironbar/commit/f929aef2d95bad19a907c402c98d3d5aa1ff3aa4) refactor: replace channel macros with ext trait methods ### 📊 Changes **50 files changed** (+657 additions, -475 deletions) <details> <summary>View changed files</summary> ➕ `src/channels.rs` (+155 -0) 📝 `src/clients/clipboard.rs` (+10 -8) 📝 `src/clients/compositor/hyprland.rs` (+31 -42) 📝 `src/clients/compositor/niri/mod.rs` (+3 -2) 📝 `src/clients/compositor/sway.rs` (+11 -13) 📝 `src/clients/libinput.rs` (+4 -3) 📝 `src/clients/music/mpd.rs` (+4 -3) 📝 `src/clients/music/mpris.rs` (+8 -5) 📝 `src/clients/swaync/mod.rs` (+3 -2) 📝 `src/clients/volume/mod.rs` (+3 -2) 📝 `src/clients/volume/sink.rs` (+6 -5) 📝 `src/clients/volume/sink_input.rs` (+6 -5) 📝 `src/clients/wayland/mod.rs` (+15 -12) 📝 `src/clients/wayland/wl_output.rs` (+13 -22) 📝 `src/clients/wayland/wlr_data_control/mod.rs` (+9 -10) 📝 `src/clients/wayland/wlr_foreign_toplevel/mod.rs` (+7 -4) 📝 `src/dynamic_value/dynamic_bool.rs` (+8 -7) 📝 `src/dynamic_value/dynamic_string.rs` (+7 -6) 📝 `src/image/provider.rs` (+5 -5) 📝 `src/ipc/server/mod.rs` (+6 -6) _...and 30 more files_ </details> ### 📄 Description Big refactor. Replaces all the macros related to channels (send/receive) with traits and extension methods, which is a little bit cleaner and should give the tooling a better shot. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 00:56:32 +01:00