mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 09:15:22 +01:00
[PR #735] [MERGED] feat: add .urgent workspace css class #5127
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#5127
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/735
Author: @Rodrigodd
Created: 9/26/2024
Status: ✅ Merged
Merged: 11/24/2024
Merged by: @JakeStanger
Base:
master← Head:feat/urgent📝 Commits (1)
afe534cfeat: add.urgentworkspace css class📊 Changes
6 files changed (+80 additions, -9 deletions)
View changed files
📝
docs/modules/Workspaces.md(+10 -9)📝
examples/style.css(+4 -0)📝
src/clients/compositor/hyprland.rs(+40 -0)📝
src/clients/compositor/mod.rs(+6 -0)📝
src/clients/compositor/sway.rs(+10 -0)📝
src/modules/workspaces.rs(+10 -0)📄 Description
Allow highlighting a workspace which contains a window that triggered a urgent event, i.e., requests attention. In my case, I see it happens when I clink a link and it opens in a new tab on firefox, and when displaying a
BELcharacter in some terminal emulators (at least in alacritty).You can test it by running
in alacritty, and switching to another workspaces before the sleep expires.
I implemented it for both Sway and Hyprland. Sway keep track of a
urgentflag for each client, and notify ironbar about changes. Hyprland or the other hand only contains a urgent event that triggers once, so I clean the urgent state of a workspace whenever it is focused.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.