[PR #360] [MERGED] Re-use existing IconTheme during icon retrieval #4878

New issue

Closed

opened 2026-05-23 00:55:40 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 00:55:40 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/360
Author: @chmanie
Created: 11/15/2023
Status: ✅ Merged
Merged: 12/3/2023
Merged by: @JakeStanger

Base: master ← Head: fix/tray-icon-themes

📝 Commits (1)

5f82b6e fix(tray): existing icons rendering as text

📊 Changes

1 file changed (+43 additions, -14 deletions)

View changed files

📝 src/modules/tray.rs (+43 -14)

📄 Description

Hey, thank you for starting this great project! This bar works just wonderfully for me.

This PR is an attempted fix for this one thing I noticed here (#358). The bar wasn't showing any icons from my icon theme, whereas the gtk example from stray worked for me.

I am no GTK expert at all, so I just compared the code. Apparently, it's important to re-use an initialized IconTheme after it was initially created (maybe it's a singleton?).

In any case, this fixes it for me. Let me know if that's an acceptable change or if I need to dig deeper here :)

Thanks again!

Closes #358

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/360 **Author:** [@chmanie](https://github.com/chmanie) **Created:** 11/15/2023 **Status:** ✅ Merged **Merged:** 12/3/2023 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/tray-icon-themes` --- ### 📝 Commits (1) - [`5f82b6e`](https://github.com/JakeStanger/ironbar/commit/5f82b6e9e0966cf22c2420fb1f584b5f94746afb) fix(tray): existing icons rendering as text ### 📊 Changes **1 file changed** (+43 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/tray.rs` (+43 -14) </details> ### 📄 Description Hey, thank you for starting this great project! This bar works just wonderfully for me. This PR is an attempted fix for this one thing I noticed here (#358). The bar wasn't showing any icons from my icon theme, whereas the [gtk example](https://github.com/JakeStanger/stray/tree/main/gtk-tray) from stray worked for me. I am no GTK expert at all, so I just compared the code. Apparently, it's important to re-use an initialized IconTheme after it was initially created (maybe it's a singleton?). In any case, this fixes it for me. Let me know if that's an acceptable change or if I need to dig deeper here :) Thanks again! Closes #358 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 00:55:40 +01:00