mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 07:15:19 +01:00
[PR #140] [MERGED] [BREAKING] module-level name and class options #4728
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#4728
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/140
Author: @JakeStanger
Created: 5/5/2023
Status: ✅ Merged
Merged: 5/6/2023
Merged by: @JakeStanger
Base:
master← Head:feat/better-styles📝 Commits (1)
dea6641feat: module-levelnameandclassoptions📊 Changes
30 files changed (+353 additions, -216 deletions)
View changed files
📝
docs/Configuration guide.md(+7 -4)📝
docs/Styling guide.md(+29 -9)📝
docs/modules/Clipboard.md(+10 -8)📝
docs/modules/Clock.md(+6 -4)📝
docs/modules/Custom.md(+8 -5)📝
docs/modules/Focused.md(+7 -5)📝
docs/modules/Label.md(+5 -3)📝
docs/modules/Launcher.md(+9 -7)📝
docs/modules/Music.md(+23 -21)📝
docs/modules/Script.md(+5 -3)📝
docs/modules/Sys-Info.md(+4 -2)📝
docs/modules/Tray.md(+4 -2)📝
docs/modules/Upower.md(+8 -6)📝
docs/modules/Workspaces.md(+5 -3)📝
examples/style.css(+32 -36)➕
scripts/migrate-styles.sh(+72 -0)📝
src/bar.rs(+7 -3)📝
src/config/common.rs(+5 -2)➕
src/gtk_helpers.rs(+8 -0)📝
src/image/gtk.rs(+4 -3)...and 10 more files
📄 Description
BREAKING CHANGE: To allow for the
nameproperty, any widgets that were previously targeted by name should be targeted by class instead. This affects all modules and all popups, as well as several widgets inside modules.This will break a lot of rules in your stylesheet. To attempt to mitigate the damage, a migration script can be found here that should get you most of the way.
Resolves #75.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.