[PR #109] [MERGED] fix(tray): icons sometimes not showing #4709

New issue

Closed

opened 2026-05-23 00:55:13 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-23 00:55:13 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/109
Author: @JakeStanger
Created: 4/16/2023
Status: ✅ Merged
Merged: 4/22/2023
Merged by: @JakeStanger

Base: master ← Head: fix/tray-icons

📝 Commits (6)

a87d8d5 fix(tray): icons sometimes not showing
15a9d8d fix(script): parser incorrectly handling colons
2463131 Merge pull request #111 from JakeStanger/fix/script-parsing
68bc823 fix(tray): icons sometimes not showing
e5ab9f3 Merge remote-tracking branch 'origin/fix/tray-icons' into fix/tray-icons
b038e76 fix(tray): icons sometimes not showing

📊 Changes

2 files changed (+118 additions, -37 deletions)

View changed files

📝 src/modules/tray.rs (+54 -7)
📝 src/script.rs (+64 -30)

📄 Description

Previously icons were only loaded from the theme based on the provided icon name. Sometimes no icon name was provided, and sometimes the name is just missing from the theme.

This falls back to using the provided pixbuf, and then falls back to just displaying the name as text if that is not available.

(Hopefully) resolves #99

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/109 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 4/16/2023 **Status:** ✅ Merged **Merged:** 4/22/2023 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/tray-icons` --- ### 📝 Commits (6) - [`a87d8d5`](https://github.com/JakeStanger/ironbar/commit/a87d8d5c3071a1d8ab149deae17d261ae97368ea) fix(tray): icons sometimes not showing - [`15a9d8d`](https://github.com/JakeStanger/ironbar/commit/15a9d8d42c9319a7062e6a90086e0c1c3323f5d8) fix(script): parser incorrectly handling colons - [`2463131`](https://github.com/JakeStanger/ironbar/commit/246313136f653c9d5ff7dc56298c2925335341a8) Merge pull request #111 from JakeStanger/fix/script-parsing - [`68bc823`](https://github.com/JakeStanger/ironbar/commit/68bc8230ddf3352cc0de9f8cc770632744c22747) fix(tray): icons sometimes not showing - [`e5ab9f3`](https://github.com/JakeStanger/ironbar/commit/e5ab9f33b5ee30f2804e8b8b6f66be779709779a) Merge remote-tracking branch 'origin/fix/tray-icons' into fix/tray-icons - [`b038e76`](https://github.com/JakeStanger/ironbar/commit/b038e7671af4bfa41060adf724deb8c6151fac1f) fix(tray): icons sometimes not showing ### 📊 Changes **2 files changed** (+118 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/tray.rs` (+54 -7) 📝 `src/script.rs` (+64 -30) </details> ### 📄 Description Previously icons were only loaded from the theme based on the provided icon name. Sometimes no icon name was provided, and sometimes the name is just missing from the theme. This falls back to using the provided pixbuf, and then falls back to just displaying the name as text if that is not available. (Hopefully) resolves #99 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-23 00:55:13 +01:00