mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 08:15:21 +01:00
[GH-ISSUE #137] Focused widget crashes whole bar when no icon present in desktop file #4290
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#4290
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ferrreo on GitHub (May 3, 2023).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/137
Describe the bug
I accidentally forgot to add an icon to my kitty.desktop file and when using the focused widget in ironbar and opening an instance of kitty the whole bar crashes
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
It should just not show an icon if there isn't one and just use the window title and not crash
System information:
Configuration
Nothing special just add focused widget with icons turned on
Additional context
Nothing in the logs or tty when it crashes it just disappears
Screenshots
N/A
@JakeStanger commented on GitHub (May 3, 2023):
Hey, would you mind sharing the .desktop file please so that I have an exact replica? Could you also let me know what icon theme you are using, and try running ironbar without explicitly setting one? I've not been able to replicate this myself.
This seems odd behaviour since plenty of icon themes have a dedicated Kitty icon (both Adwaita and Paper at least), so it will use that before ever hitting the desktop file. If it does get as far as reading the desktop file, Ironbar should just silently continue or log an error if an icon entry can't be found. I wonder if it's coming from GTK, hence the hard crash.
@ferrreo commented on GitHub (May 9, 2023):
[Desktop Entry]
Version=1.0
Type=Application
Name=kitty
GenericName=Terminal emulator
Comment=Fast, feature-rich, GPU based terminal
TryExec=kitty
Exec=kitty
Icon=kitty
Categories=System;TerminalEmulator;
This is a default kitty desktop file that causes the issue. To fix I put a full path to the icon provided alongside kitty.
@JakeStanger commented on GitHub (May 9, 2023):
That file works fine for me.
I also merged a change to some of the icon/image handling earlier today. It might be worth trying to update to the latest commit and see if the issue still occurs / if it produces any output?
@ferrreo commented on GitHub (May 11, 2023):
I can't replicate it now even on older builds, so I guess we should put it down to gtk doing something super weird at the time.
@JakeStanger commented on GitHub (May 15, 2023):
Okay cool, thanks for confirming. I'll close this for now but if you do encounter it again please let me know and I'll reopen.