[PR #1283] [MERGED] fix(tray): redraw icon when name or pixmap changes #4091

New issue

Closed

opened 2026-05-22 23:57:41 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 23:57:41 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1283
Author: @Windblows2000
Created: 12/18/2025
Status: ✅ Merged
Merged: 12/18/2025
Merged by: @JakeStanger

Base: master ← Head: master

📝 Commits (1)

36fca2c fix(tray): redraw icon when name or pixmap changes

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 src/modules/tray/mod.rs (+5 -2)

📄 Description

Summary

Redraw tray icons when either IconName or IconPixmap changes.

Motivation

Some SNI clients (e.g. Electron apps, nm-applet) update only one of these fields or omit IconPixmap, which caused icons not to refresh.

Notes

Tested with nm-applet animation (high-frequency icon updates)
Duplicate updates are filtered; no menu re-rendering observed
cargo build --no-default-features emits existing dead-code warnings due to disabled features; no new warnings introduced

Fixes #1279

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1283 **Author:** [@Windblows2000](https://github.com/Windblows2000) **Created:** 12/18/2025 **Status:** ✅ Merged **Merged:** 12/18/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`36fca2c`](https://github.com/JakeStanger/ironbar/commit/36fca2cb326806a00076fa48a9b23690274b18de) fix(tray): redraw icon when name or pixmap changes ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/tray/mod.rs` (+5 -2) </details> ### 📄 Description ### Summary Redraw tray icons when either `IconName` or `IconPixmap` changes. ### Motivation Some SNI clients (e.g. Electron apps, nm-applet) update only one of these fields or omit `IconPixmap`, which caused icons not to refresh. ### Notes - Tested with nm-applet animation (high-frequency icon updates) - Duplicate updates are filtered; no menu re-rendering observed - `cargo build --no-default-features` emits existing dead-code warnings due to disabled features; no new warnings introduced Fixes #1279 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 23:57:41 +01:00