[PR #1285] [MERGED] Fix tray icon selection #4090

New issue

Closed

opened 2026-05-22 23:57:41 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 23:57:41 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1285
Author: @JakeStanger
Created: 12/18/2025
Status: ✅ Merged
Merged: 12/18/2025
Merged by: @JakeStanger

Base: master ← Head: fix/tray-scaling

📝 Commits (2)

bb83ca7 refactor(tray): remove unrequired ffi binding for icon search path
239461b fix(tray): improve pixmap selection algorithm

📊 Changes

2 files changed (+70 additions, -29 deletions)

View changed files

📝 src/modules/tray/icon.rs (+67 -27)
📝 src/modules/tray/interface.rs (+3 -2)

📄 Description

Improves the tray icon pixmap selection algorithm to:

handle finding icons if they are not sent in size order
pick the largest icon if none meet the requested size

Fixes #809
Superseeds #812

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1285 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 12/18/2025 **Status:** ✅ Merged **Merged:** 12/18/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/tray-scaling` --- ### 📝 Commits (2) - [`bb83ca7`](https://github.com/JakeStanger/ironbar/commit/bb83ca7aa292c799ca6f47955b6ca6df7d0ffe65) refactor(tray): remove unrequired ffi binding for icon search path - [`239461b`](https://github.com/JakeStanger/ironbar/commit/239461b9ef9405fe533db1bb5b39df2d775ba121) fix(tray): improve pixmap selection algorithm ### 📊 Changes **2 files changed** (+70 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/tray/icon.rs` (+67 -27) 📝 `src/modules/tray/interface.rs` (+3 -2) </details> ### 📄 Description Improves the tray icon pixmap selection algorithm to: - handle finding icons if they are not sent in size order - pick the largest icon if none meet the requested size Fixes #809 Superseeds #812 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 23:57:41 +01:00