[PR #1267] [MERGED] fix(image): restore scheme and run http fetch on tokio runtime #4079

New issue

Closed

opened 2026-05-22 23:57:38 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 23:57:38 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1267
Author: @slowsage
Created: 12/1/2025
Status: ✅ Merged
Merged: 12/1/2025
Merged by: @JakeStanger

Base: master ← Head: fix/1261

📝 Commits (1)

bba5340 fix(image): restore scheme and run http fetch on tokio runtime

📊 Changes

1 file changed (+23 additions, -15 deletions)

View changed files

📝 src/image/provider.rs (+23 -15)

📄 Description

URL split on ':' strips scheme from input_name, causing parse failure.
reqwest requires tokio context, was called from glib async.
Use spawn + oneshot pattern to bridge tokio and glib.

Fixes #1261

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1267 **Author:** [@slowsage](https://github.com/slowsage) **Created:** 12/1/2025 **Status:** ✅ Merged **Merged:** 12/1/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/1261` --- ### 📝 Commits (1) - [`bba5340`](https://github.com/JakeStanger/ironbar/commit/bba534081416e1e60eb1894467094462ed6e77a1) fix(image): restore scheme and run http fetch on tokio runtime ### 📊 Changes **1 file changed** (+23 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/image/provider.rs` (+23 -15) </details> ### 📄 Description URL split on ':' strips scheme from input_name, causing parse failure. reqwest requires tokio context, was called from glib async. Use spawn + oneshot pattern to bridge tokio and glib. Fixes #1261 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 23:57:38 +01:00