[PR #1198] [MERGED] Fix race condition on monitor connection preventing bar creation #4031

New issue

Closed

opened 2026-05-22 23:57:30 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 23:57:30 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1198
Author: @azertyfun
Created: 10/18/2025
Status: ✅ Merged
Merged: 10/22/2025
Merged by: @JakeStanger

Base: master ← Head: fix/hyprland-monitor-events

📝 Commits (4)

6db1517 fix(bar) destroy window when Bar is dropped
d2d6912 fix(outputs): ensure monitor is available in GDK before creating bar
d793ad8 fix(outputs): compilation with --no-default-features
d0c6a37 fix(outputs): implement code review feedback

📊 Changes

7 files changed (+290 additions, -58 deletions)

View changed files

📝 src/bar.rs (+7 -0)
📝 src/clients/mod.rs (+8 -0)
➕ src/clients/outputs.rs (+195 -0)
📝 src/clients/wayland/mod.rs (+0 -3)
📝 src/clients/wayland/wl_output.rs (+0 -2)
📝 src/ipc/server/mod.rs (+3 -9)
📝 src/main.rs (+77 -44)

📄 Description

As discussed in #1196

I don't have a ton of experience in Rust, so if I've implemented some anti-patterns I'd be happy to fix them if you point them out.

Cheers!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1198 **Author:** [@azertyfun](https://github.com/azertyfun) **Created:** 10/18/2025 **Status:** ✅ Merged **Merged:** 10/22/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/hyprland-monitor-events` --- ### 📝 Commits (4) - [`6db1517`](https://github.com/JakeStanger/ironbar/commit/6db151763b261963cb98dd45a44a03b4bd3aba6d) fix(bar) destroy window when Bar is dropped - [`d2d6912`](https://github.com/JakeStanger/ironbar/commit/d2d69120cc806f283cf65444d77d90a7a5f73e82) fix(outputs): ensure monitor is available in GDK before creating bar - [`d793ad8`](https://github.com/JakeStanger/ironbar/commit/d793ad8180f37c35e7e4dc01f4bb5da526fc07b3) fix(outputs): compilation with --no-default-features - [`d0c6a37`](https://github.com/JakeStanger/ironbar/commit/d0c6a37ab34ce04a9479145cf28315667e2fadfe) fix(outputs): implement code review feedback ### 📊 Changes **7 files changed** (+290 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `src/bar.rs` (+7 -0) 📝 `src/clients/mod.rs` (+8 -0) ➕ `src/clients/outputs.rs` (+195 -0) 📝 `src/clients/wayland/mod.rs` (+0 -3) 📝 `src/clients/wayland/wl_output.rs` (+0 -2) 📝 `src/ipc/server/mod.rs` (+3 -9) 📝 `src/main.rs` (+77 -44) </details> ### 📄 Description As discussed in #1196 I don't have a ton of experience in Rust, so if I've implemented some anti-patterns I'd be happy to fix them if you point them out. Cheers! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 23:57:30 +01:00