[PR #1141] [MERGED] refactor(music): remove regex dependency #3990

New issue

Closed

opened 2026-05-22 23:57:24 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 23:57:24 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1141
Author: @JakeStanger
Created: 9/5/2025
Status: ✅ Merged
Merged: 9/5/2025
Merged by: @JakeStanger

Base: master ← Head: refactor/music-regex

📝 Commits (1)

cce6adc refactor(music): remove regex dependency

📊 Changes

3 files changed (+33 additions, -50 deletions)

View changed files

📝 Cargo.lock (+0 -13)
📝 Cargo.toml (+1 -4)
📝 src/modules/music/mod.rs (+32 -33)

📄 Description

Rather than some complicated regex based token replace system...we can just perform a bunch of .replace calls on the string for the token literals...

Groundbreaking.

Fixes #1139

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1141 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 9/5/2025 **Status:** ✅ Merged **Merged:** 9/5/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `refactor/music-regex` --- ### 📝 Commits (1) - [`cce6adc`](https://github.com/JakeStanger/ironbar/commit/cce6adcad5993e956fc9c3b097fdd7df788ff181) refactor(music): remove regex dependency ### 📊 Changes **3 files changed** (+33 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+0 -13) 📝 `Cargo.toml` (+1 -4) 📝 `src/modules/music/mod.rs` (+32 -33) </details> ### 📄 Description Rather than some complicated regex based token replace system...we can just perform a bunch of `.replace` calls on the string for the token literals... Groundbreaking. Fixes #1139 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 23:57:24 +01:00