[PR #996] [MERGED] refactor(module): remove redundant `into_popup` parameters #3897

New issue

Closed

opened 2026-05-22 23:57:07 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 23:57:07 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/996
Author: @JakeStanger
Created: 5/19/2025
Status: ✅ Merged
Merged: 5/19/2025
Merged by: @JakeStanger

Base: master ← Head: refactor/into-popup

📝 Commits (1)

8575300 refactor(module): remove redundant into_popup parameters

📊 Changes

8 files changed (+41 additions, -77 deletions)

View changed files

📝 src/modules/clipboard.rs (+6 -9)
📝 src/modules/clock.rs (+4 -11)
📝 src/modules/custom/mod.rs (+3 -10)
📝 src/modules/launcher/mod.rs (+6 -11)
📝 src/modules/mod.rs (+0 -2)
📝 src/modules/music/mod.rs (+10 -12)
📝 src/modules/upower.rs (+4 -7)
📝 src/modules/volume.rs (+8 -15)

📄 Description

Removes unnecessary tx and rx params as values were always directly from context, which is also passed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/996 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 5/19/2025 **Status:** ✅ Merged **Merged:** 5/19/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `refactor/into-popup` --- ### 📝 Commits (1) - [`8575300`](https://github.com/JakeStanger/ironbar/commit/857530004497f00cb2fabfa5f70aea3f72e682a1) refactor(module): remove redundant `into_popup` parameters ### 📊 Changes **8 files changed** (+41 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/clipboard.rs` (+6 -9) 📝 `src/modules/clock.rs` (+4 -11) 📝 `src/modules/custom/mod.rs` (+3 -10) 📝 `src/modules/launcher/mod.rs` (+6 -11) 📝 `src/modules/mod.rs` (+0 -2) 📝 `src/modules/music/mod.rs` (+10 -12) 📝 `src/modules/upower.rs` (+4 -7) 📝 `src/modules/volume.rs` (+8 -15) </details> ### 📄 Description Removes unnecessary `tx` and `rx` params as values were always directly from context, which is also passed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 23:57:07 +01:00