[PR #983] [MERGED] fix(bindmode): hide bindmode label if it's empty #3888

New issue

Closed

opened 2026-05-22 23:57:06 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 23:57:06 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/983
Author: @postsolar
Created: 5/16/2025
Status: ✅ Merged
Merged: 5/18/2025
Merged by: @JakeStanger

Base: master ← Head: hide-empty-bindmode

📝 Commits (2)

f6598f4 Hide bindmode label if it's empty
aa2d824 Send a dummy event on init so that the widget starts hidden

📊 Changes

1 file changed (+16 additions, -1 deletions)

View changed files

📝 src/modules/bindmode.rs (+16 -1)

📄 Description

Closes #982

This works but I'm not sure how to also make it hidden upon initialization (needed because there would be no BindModeUpdate's at this point yet). Tried to insert label.hide() right after building the widget but it doesn't work.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/983 **Author:** [@postsolar](https://github.com/postsolar) **Created:** 5/16/2025 **Status:** ✅ Merged **Merged:** 5/18/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `hide-empty-bindmode` --- ### 📝 Commits (2) - [`f6598f4`](https://github.com/JakeStanger/ironbar/commit/f6598f46d592d5438d28d553871e4bad8d3e906a) Hide bindmode label if it's empty - [`aa2d824`](https://github.com/JakeStanger/ironbar/commit/aa2d82469fba1f80d7764e8b05d1347e25ae347a) Send a dummy event on init so that the widget starts hidden ### 📊 Changes **1 file changed** (+16 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/bindmode.rs` (+16 -1) </details> ### 📄 Description Closes #982 This works but I'm not sure how to also make it hidden upon initialization (needed because there would be no `BindModeUpdate`'s at this point yet). Tried to insert `label.hide()` right after building the widget but it doesn't work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 23:57:06 +01:00