[PR #863] [MERGED] Fixes clipboard deadlocking data sources #3817

New issue

Closed

opened 2026-05-22 23:56:53 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 23:56:53 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/863
Author: @ToxicMushroom
Created: 2/6/2025
Status: ✅ Merged
Merged: 2/6/2025
Merged by: @JakeStanger

Base: master ← Head: fix-clipboard-blocks

📝 Commits (2)

d739fb9 Change clipboard calloop event loop with blocking read to tokio async readers.
7c13a8e cargo fmt

📊 Changes

4 files changed (+32 additions, -82 deletions)

View changed files

📝 .idea/runConfigurations/Run__Live_Config_.xml (+1 -1)
📝 src/clients/wayland/mod.rs (+1 -8)
📝 src/clients/wayland/wlr_data_control/mod.rs (+24 -64)
📝 src/clients/wayland/wlr_data_control/offer.rs (+6 -9)

📄 Description

Wayland spec says clients should read the offers they request receive on.
Ironbar was failing to do this because the event loop it used could get deadlocked on reading a pipe.

This pr fixes that by switching to tokio's async readers

Thanks @zeroeightysix

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/863 **Author:** [@ToxicMushroom](https://github.com/ToxicMushroom) **Created:** 2/6/2025 **Status:** ✅ Merged **Merged:** 2/6/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix-clipboard-blocks` --- ### 📝 Commits (2) - [`d739fb9`](https://github.com/JakeStanger/ironbar/commit/d739fb9fedb37f85339a1bca8fa8b7334b955622) Change clipboard calloop event loop with blocking read to tokio async readers. - [`7c13a8e`](https://github.com/JakeStanger/ironbar/commit/7c13a8e0ee2e575a1b4a03be7fb36d3b846263e8) cargo fmt ### 📊 Changes **4 files changed** (+32 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `.idea/runConfigurations/Run__Live_Config_.xml` (+1 -1) 📝 `src/clients/wayland/mod.rs` (+1 -8) 📝 `src/clients/wayland/wlr_data_control/mod.rs` (+24 -64) 📝 `src/clients/wayland/wlr_data_control/offer.rs` (+6 -9) </details> ### 📄 Description Wayland spec says clients should read the offers they request receive on. Ironbar was failing to do this because the event loop it used could get deadlocked on reading a pipe. This pr fixes that by switching to tokio's async readers Thanks @zeroeightysix --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 23:56:53 +01:00