[PR #837] [MERGED] feat: icon overrides #3794

Closed
opened 2026-05-22 23:56:49 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/837
Author: @BowDown097
Created: 1/11/2025
Status: Merged
Merged: 2/15/2025
Merged by: @JakeStanger

Base: masterHead: master


📝 Commits (6)

  • 87c6801 feat(launcher): icon overrides
  • d1b4af4 refactor: make icon overrides bar-level and apply to focused module
  • 40d449e refactor: address requested changes
  • d5e4e08 refactor: address requested changes (2)
  • 2fd49e0 refactor: address requested changes (3)
  • c2beda8 refactor: ensure one copy of icon_overrides

📊 Changes

9 files changed (+77 additions, -18 deletions)

View changed files

📝 docs/Configuration guide.md (+6 -5)
📝 docs/modules/Launcher.md (+1 -1)
📝 src/bar.rs (+15 -1)
📝 src/config/mod.rs (+7 -0)
📝 src/main.rs (+4 -0)
📝 src/modules/focused.rs (+9 -4)
📝 src/modules/launcher/item.rs (+12 -2)
📝 src/modules/launcher/mod.rs (+21 -5)
📝 src/modules/mod.rs (+2 -0)

📄 Description

This allows the user to override an app's icon in the launcher with a specified icon name. The only alternative to this currently is to dig through your icon theme's folder and replace existing entries / manually add entries yourself, which is rather inconvenient.

I thought about instead adding functionality to look for an associated desktop file and use the icon from that if one is found, but I'm not sure how I would address the problem of app IDs not having to match the desktop file name, or anything in the file.

Example:

icon_overrides = { legcord = "discord" }

    Before         After


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/837 **Author:** [@BowDown097](https://github.com/BowDown097) **Created:** 1/11/2025 **Status:** ✅ Merged **Merged:** 2/15/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`87c6801`](https://github.com/JakeStanger/ironbar/commit/87c680122b673afd50d27a89389a1e04ea8dc48c) feat(launcher): icon overrides - [`d1b4af4`](https://github.com/JakeStanger/ironbar/commit/d1b4af47105e6904d4790f8c9f5fde3929731fe0) refactor: make icon overrides bar-level and apply to focused module - [`40d449e`](https://github.com/JakeStanger/ironbar/commit/40d449e011f83175b9a69251ee827d5a1af32dca) refactor: address requested changes - [`d5e4e08`](https://github.com/JakeStanger/ironbar/commit/d5e4e08863266d1373c74c7a9f8b75cc27220d38) refactor: address requested changes (2) - [`2fd49e0`](https://github.com/JakeStanger/ironbar/commit/2fd49e0f3a4e08289d4d3553218529d7efbd9144) refactor: address requested changes (3) - [`c2beda8`](https://github.com/JakeStanger/ironbar/commit/c2beda852d5183fa6ee8874b8e19b15757fe06c2) refactor: ensure one copy of icon_overrides ### 📊 Changes **9 files changed** (+77 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `docs/Configuration guide.md` (+6 -5) 📝 `docs/modules/Launcher.md` (+1 -1) 📝 `src/bar.rs` (+15 -1) 📝 `src/config/mod.rs` (+7 -0) 📝 `src/main.rs` (+4 -0) 📝 `src/modules/focused.rs` (+9 -4) 📝 `src/modules/launcher/item.rs` (+12 -2) 📝 `src/modules/launcher/mod.rs` (+21 -5) 📝 `src/modules/mod.rs` (+2 -0) </details> ### 📄 Description This allows the user to override an app's icon in the launcher with a specified icon name. The only alternative to this currently is to dig through your icon theme's folder and replace existing entries / manually add entries yourself, which is rather inconvenient. I thought about instead adding functionality to look for an associated desktop file and use the icon from that if one is found, but I'm not sure how I would address the problem of app IDs not having to match the desktop file name, or anything in the file. Example: ```toml icon_overrides = { legcord = "discord" } ``` <p>&nbsp;&nbsp;&nbsp;&nbsp;Before&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;After</p> <img src="https://github.com/user-attachments/assets/95b5b148-3372-4f37-b1d2-c6c4b8b9d577"/> <img src="https://github.com/user-attachments/assets/f491f8fb-fc0f-4dbc-b649-a1b8fb4b5e82"/> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-22 23:56:49 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#3794
No description provided.