mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 06:15:21 +01:00
[PR #572] [MERGED] fix(workspaces): add support for hyprland rename event #3620
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#3620
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/572
Author: @JakeStanger
Created: 5/6/2024
Status: ✅ Merged
Merged: 5/7/2024
Merged by: @JakeStanger
Base:
master← Head:fix/workspace-rename📝 Commits (1)
5e7f576fix(workspaces): add support for hyprland rename event📊 Changes
5 files changed (+51 additions, -20 deletions)
View changed files
📝
Cargo.lock(+4 -4)📝
Cargo.toml(+1 -1)📝
src/clients/compositor/hyprland.rs(+19 -4)📝
src/clients/compositor/mod.rs(+6 -0)📝
src/modules/workspaces.rs(+21 -11)📄 Description
Renaming workspaces on Hyprland will now work as expected.
This also refactors the workspace code to depend on IDs rather than names which should make it more robust against the same sort of issue in future.
Fixes #469
Draft until new hyprland-rs alpha releases
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.