mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 09:15:22 +01:00
[PR #505] [MERGED] Native modules inside custom modules #3579
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#3579
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/505
Author: @JakeStanger
Created: 3/20/2024
Status: ✅ Merged
Merged: 4/1/2024
Merged by: @JakeStanger
Base:
master← Head:feat/modules-in-custom📝 Commits (3)
994f4a4feat: ability to add custom modules instead native modules46cbacafeat: option to disable module popupee8873adocs(custom): add native examples📊 Changes
23 files changed (+518 additions, -253 deletions)
View changed files
📝
docs/Configuration guide.md(+1 -0)📝
docs/modules/Custom.md(+24 -2)📝
src/bar.rs(+3 -50)📝
src/config/common.rs(+1 -0)📝
src/config/mod.rs(+46 -0)📝
src/ipc/server.rs(+2 -2)📝
src/macros.rs(+28 -0)📝
src/modules/clipboard.rs(+4 -5)📝
src/modules/clock.rs(+9 -5)📝
src/modules/custom/mod.rs(+55 -9)📝
src/modules/focused.rs(+2 -4)📝
src/modules/label.rs(+2 -4)📝
src/modules/launcher/mod.rs(+4 -5)📝
src/modules/mod.rs(+287 -115)📝
src/modules/music/mod.rs(+4 -5)📝
src/modules/notifications.rs(+2 -4)📝
src/modules/script.rs(+2 -4)📝
src/modules/sysinfo.rs(+2 -4)📝
src/modules/tray/mod.rs(+2 -4)📝
src/modules/upower.rs(+4 -5)...and 3 more files
📄 Description
Adds ability to put native modules inside custom modules.
This works apart from a few (relatively) edge case. The code also needs refactoring.
Sticking this up for now so it's available - will revisit to get across the line in the near future.
Resolves #131.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.