mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 07:15:19 +01:00
[PR #477] Added support for getting the cover art from mpd #3558
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#3558
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/477
Author: @eternalfrustation
Created: 2/27/2024
Status: 🔄 Open
Base:
master← Head:album_art_from_file📝 Commits (10+)
666188eAdded support for using a cover image which has a specific static path in the music module5fe8e54Added support for using kbps, kBps for total network usaged7d0042Added support for getting the cover art from mpd4505cb5Satisfying Clippy9f19b54feat: Modifying the image via message passing6152483fix: Removed the path section from Cargo.toml30113fbfix: Ran cargo update5a68847fix: Removed the image crate from dependenciesb527ae7fix: Moved the Cacellable and MemoryStream imports out of the cfg_if blocka5eb6f3fix: Only sending the GetAlbumArt signal when needed📊 Changes
10 files changed (+316 additions, -4252 deletions)
View changed files
➖
Cargo.lock(+0 -4103)📝
Cargo.toml(+2 -1)📝
src/clients/music/mod.rs(+4 -0)📝
src/clients/music/mpd.rs(+116 -27)📝
src/clients/music/mpris.rs(+9 -0)📝
src/image/provider.rs(+25 -20)📝
src/modules/mod.rs(+0 -1)📝
src/modules/music/config.rs(+4 -2)📝
src/modules/music/mod.rs(+119 -95)📝
src/modules/sysinfo.rs(+37 -3)📄 Description
As proposed in the previous PR (#466), this PR implements displaying cover art from mpd using the readpicture command
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.