[PR #259] [MERGED] Image fixes #3395

New issue

Closed

opened 2026-05-22 23:55:41 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 23:55:41 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/259
Author: @JakeStanger
Created: 7/26/2023
Status: ✅ Merged
Merged: 7/26/2023
Merged by: @JakeStanger

Base: master ← Head: fix/images

📝 Commits (4)

2367faa fix(image): using fallback in places it shouldn't
36f3db7 refactor(image): do not try to read desktop files where definitely not necessary
7f6fef6 fix(image): matching desktop file names too eagerly
89ec06f fix(music): hide album art widget when no image

📊 Changes

8 files changed (+38 additions, -18 deletions)

View changed files

📝 src/desktop_file.rs (+1 -1)
📝 src/image/gtk.rs (+2 -2)
📝 src/image/provider.rs (+28 -10)
📝 src/modules/custom/image.rs (+1 -1)
📝 src/modules/focused.rs (+1 -1)
📝 src/modules/launcher/item.rs (+1 -1)
📝 src/modules/music/mod.rs (+3 -1)
📝 src/modules/upower.rs (+1 -1)

📄 Description

Includes several small fixes and optimizations.

Fixes #228.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/259 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 7/26/2023 **Status:** ✅ Merged **Merged:** 7/26/2023 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/images` --- ### 📝 Commits (4) - [`2367faa`](https://github.com/JakeStanger/ironbar/commit/2367faab0440327620052de845c6a0d3032f2f05) fix(image): using fallback in places it shouldn't - [`36f3db7`](https://github.com/JakeStanger/ironbar/commit/36f3db741178b959070ee90bcd6448e1b2a6ef26) refactor(image): do not try to read desktop files where definitely not necessary - [`7f6fef6`](https://github.com/JakeStanger/ironbar/commit/7f6fef6338d7a8c909f3224b32426dfc2aacc295) fix(image): matching desktop file names too eagerly - [`89ec06f`](https://github.com/JakeStanger/ironbar/commit/89ec06fc7b252052f96e45f5d0f6d6504878a13a) fix(music): hide album art widget when no image ### 📊 Changes **8 files changed** (+38 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/desktop_file.rs` (+1 -1) 📝 `src/image/gtk.rs` (+2 -2) 📝 `src/image/provider.rs` (+28 -10) 📝 `src/modules/custom/image.rs` (+1 -1) 📝 `src/modules/focused.rs` (+1 -1) 📝 `src/modules/launcher/item.rs` (+1 -1) 📝 `src/modules/music/mod.rs` (+3 -1) 📝 `src/modules/upower.rs` (+1 -1) </details> ### 📄 Description Includes several small fixes and optimizations. Fixes #228. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 23:55:41 +01:00