mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 08:15:21 +01:00
[GH-ISSUE #533] Ghost workspace icons with steam #2984
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#2984
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @noah427 on GitHub (Apr 6, 2024).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/533
Describe the bug
opening and closing the steam window causes the workspace module to leave behind ghost workspaces.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
the workspace icon disappears when the steam window is no longer in it
System information:
Configuration
config.json
Videos
https://github.com/JakeStanger/ironbar/assets/40678304/bfb19919-6503-430f-829c-3c191372e639
https://github.com/JakeStanger/ironbar/assets/40678304/3e851ae9-bbe2-4ed1-bf72-a25f0a470ffd
@yavko commented on GitHub (Apr 6, 2024):
Unless for some reason steam leaves open clients on that workspace, which prevent the workspace close event, I don't know what else it could be
@JakeStanger commented on GitHub (Apr 6, 2024):
There's something funny going on and it's not Steam. You can see in your first video you manage to open a duplicate
3workspace almost immediately, but I can't easily reproduce that. It's like the existing workspace button is out of sync and shouldn't be there?If you restart Ironbar, are you able to easily reproduce that in particular? If you are, can you also provide logs with
IRONBAR_LOG=debugplease?@noah427 commented on GitHub (Apr 7, 2024):
I can reproduce it every single time I restart ironbar. Here's a log file I recorded while I recreated the issue. Hopefully this sheds some light on the problem
log.txt
@JakeStanger commented on GitHub (Apr 10, 2024):
Right, bear with me because I'm struggling to replicate it and I'm still trying to make sense of the issue.
I've mapped out the workspace state changes below based on the log file. An asterisk
*indicates it's focused. Workspaces being added/removed happens before/after the focus event respectively, which is why it's a bit verbose.The 2nd time that you move to workspace 4, it looks like workspace 3 never receives a destroy event.
That would indicate Ironbar is probably behaving correctly, as it's interpreting the events it receives and is never told to remove the client.
I would suggest the next step is to find out what the Hyprland event socket is actually sending. You can do something like this:
The following events are of particular interest:
focusedmon- includes workspace focus change if you change focused outputcreateworkspaceworkspace- focusing a workspace on the same outputdestroyworkspace- this is the one you want to watch especiallyAlso, I could see in your log that each workspace event is received twice. Normally, that'd indicate two running workspace modules (ie two bars on two different screens), but the log suggested you only have a single monitor. Any idea what's going on there?
@noah427 commented on GitHub (Apr 10, 2024):
I actually do have two bars, one on each monitor. Not sure why the logs don't show that. I'll check on the hyprland event socket later today and report back with what I find. My current theory is that there's some issue with applications that spawn floating tiles because that's the pattern I've noticed with the problems so far. Thanks for all your help so far!
@JakeStanger commented on GitHub (Apr 10, 2024):
Ah they do to some extent, but every workspace event is logged on DP-1 and it suggests no workspaces ever exist on DP-2. Which seems wrong and odd. That could be a bug with the actual log code...
@noah427 commented on GitHub (Apr 11, 2024):
Here's what I see while reproducing this issue with the socket open
@JakeStanger commented on GitHub (Apr 11, 2024):
So in this case you were just switching between workspace 1 and 2? I think I've interpreted the workspace changes as follows:
(beginning to feel like some advent of code input...)
The log here suggests all is fine. What I might need to do then is try some small-scale test and see if we can pin down exactly where in the pipeline the issue is.
It's damn annoying I can't replicate this myself too.
@JakeStanger commented on GitHub (Apr 24, 2024):
Going to close this issue as I've had confirmation from @noah427 that various system updates have resolved this