[PR #1485] [MERGED] fix(tray): empty icon names being incorrectly loaded #2806

New issue

Closed

opened 2026-05-22 22:57:53 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 22:57:53 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1485
Author: @JakeStanger
Created: 5/11/2026
Status: ✅ Merged
Merged: 5/12/2026
Merged by: @JakeStanger

Base: master ← Head: fix/tray-icon

📝 Commits (1)

dcff995 fix(tray): empty icon names being incorrectly loaded

📊 Changes

1 file changed (+115 additions, -16 deletions)

View changed files

📝 src/modules/tray/icon.rs (+115 -16)

📄 Description

Rewrites the logic around picking which icon loader to use to be far more robust, and testable. Also adds tests to test the testable code.

Fixes #1335

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1485 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 5/11/2026 **Status:** ✅ Merged **Merged:** 5/12/2026 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/tray-icon` --- ### 📝 Commits (1) - [`dcff995`](https://github.com/JakeStanger/ironbar/commit/dcff99580bd05d62be2542986bd0fffb5ce21f69) fix(tray): empty icon names being incorrectly loaded ### 📊 Changes **1 file changed** (+115 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/tray/icon.rs` (+115 -16) </details> ### 📄 Description Rewrites the logic around picking which icon loader to use to be far more robust, and testable. Also adds tests to test the testable code. Fixes #1335 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 22:57:53 +01:00