[PR #1424] [MERGED] fix(network-manager): not accepting char to display icons #2769

New issue

Closed

opened 2026-05-22 22:57:47 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 22:57:47 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1424
Author: @MrFantOlas
Created: 3/17/2026
Status: ✅ Merged
Merged: 4/25/2026
Merged by: @JakeStanger

Base: master ← Head: master

📝 Commits (1)

45896e8 fix(network-manager): not accepting char to display icons

📊 Changes

3 files changed (+30 additions, -32 deletions)

View changed files

📝 src/image/gtk.rs (+5 -2)
📝 src/image/mod.rs (+4 -2)
📝 src/modules/networkmanager.rs (+21 -28)

📄 Description

Fixes #1423

As it is my first PR here it is hopefully not too bad.
Also note that I had no previous Gtk experience so if I did something atrocious, please point it out.

Questions that still remains:
Should all icons contain "icon:" ? From what I understand specifying a path should also be accepted. Maybe a better condition there would be good or a rule to differentiate icons from custom text.

Opening this as draft since I could not find a satisfying answer to that question.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1424 **Author:** [@MrFantOlas](https://github.com/MrFantOlas) **Created:** 3/17/2026 **Status:** ✅ Merged **Merged:** 4/25/2026 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`45896e8`](https://github.com/JakeStanger/ironbar/commit/45896e858ca32ae9471f5b4bac03bc2ec30deb57) fix(network-manager): not accepting char to display icons ### 📊 Changes **3 files changed** (+30 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `src/image/gtk.rs` (+5 -2) 📝 `src/image/mod.rs` (+4 -2) 📝 `src/modules/networkmanager.rs` (+21 -28) </details> ### 📄 Description Fixes #1423 As it is my first PR here it is hopefully not too bad. Also note that I had no previous Gtk experience so if I did something atrocious, please point it out. Questions that still remains: Should all icons contain "icon:" ? From what I understand specifying a path should also be accepted. Maybe a better condition there would be good or a rule to differentiate icons from custom text. Opening this as draft since I could not find a satisfying answer to that question. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 22:57:47 +01:00