[PR #1260] [MERGED] More IPC popup fixes #2667

Closed
opened 2026-05-22 22:57:29 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1260
Author: @JakeStanger
Created: 11/25/2025
Status: Merged
Merged: 11/25/2025
Merged by: @JakeStanger

Base: masterHead: fix/ipc-popup2


📝 Commits (2)

  • 9c141dd fix(ipc): crash handling error from bar
  • a067914 fix(ipc): popup commands broken for custom module

📊 Changes

5 files changed (+25 additions, -26 deletions)

View changed files

📝 src/ipc/server/bar.rs (+5 -5)
📝 src/ipc/server/style.rs (+5 -5)
📝 src/modules/launcher/mod.rs (+2 -1)
📝 src/modules/mod.rs (+9 -9)
📝 src/popup.rs (+4 -6)

📄 Description

Resolves #1248

This is hacks on top of hacks at this point, but it fixes the problem for now.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1260 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 11/25/2025 **Status:** ✅ Merged **Merged:** 11/25/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/ipc-popup2` --- ### 📝 Commits (2) - [`9c141dd`](https://github.com/JakeStanger/ironbar/commit/9c141ddb34e3d5c261516647421258518029a33c) fix(ipc): crash handling error from bar - [`a067914`](https://github.com/JakeStanger/ironbar/commit/a067914a246237f780d7f9f7b2ae61e02820bf12) fix(ipc): popup commands broken for custom module ### 📊 Changes **5 files changed** (+25 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/ipc/server/bar.rs` (+5 -5) 📝 `src/ipc/server/style.rs` (+5 -5) 📝 `src/modules/launcher/mod.rs` (+2 -1) 📝 `src/modules/mod.rs` (+9 -9) 📝 `src/popup.rs` (+4 -6) </details> ### 📄 Description Resolves #1248 This is hacks on top of hacks at this point, but it fixes the problem for now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-22 22:57:29 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#2667
No description provided.