mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 06:15:21 +01:00
[PR #1250] [MERGED] feat: add marquee effect to volume popup's audio inputs #2659
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#2659
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/1250
Author: @postsolar
Created: 11/23/2025
Status: ✅ Merged
Merged: 12/17/2025
Merged by: @JakeStanger
Base:
master← Head:feat/volume-popup-marquee-gtk4📝 Commits (1)
d03aeabfeat(volume): marquee effect for volume audio inputs📊 Changes
6 files changed (+315 additions, -26 deletions)
View changed files
📝
docs/modules/Volume.md(+20 -13)📝
src/clients/volume/sink_input.rs(+10 -5)➕
src/config/marquee.rs(+74 -0)📝
src/config/mod.rs(+2 -0)📝
src/gtk_helpers.rs(+166 -3)📝
src/modules/volume.rs(+43 -5)📄 Description
Part of #1011. Based on #1066 - GTK4 actually fixes that scrollbars bug, so pretty much no changes aside from updating to GTK4 and expanding what's configurable.
Overview
Known issues
None so far.
Limitations and future considerations
It's opt-in so no breaking changes, but anyone wishing to use might need to update their CSS (implementation details leak a bit):
For future extensions of other modules, even aside from just music (and its popup) I could see a lot of use-cases for making every Label scrollable like this. But this will necessarily mean replicating the same less-than-perfect UX pattern with regards to user CSS - wanted to hear your thoughts @JakeStanger on this.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.