mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 07:15:19 +01:00
[PR #1241] [MERGED] fix(image): symbolic icons not rendering in GTK 4.20+ #2655
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#2655
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/JakeStanger/ironbar/pull/1241
Author: @slowsage
Created: 11/19/2025
Status: ✅ Merged
Merged: 12/17/2025
Merged by: @JakeStanger
Base:
master← Head:symbolic📝 Commits (1)
99e3e40fix(image): symbolic icons not rendering in GTK 4.20+📊 Changes
2 files changed (+127 additions, -111 deletions)
View changed files
📝
src/image/gtk.rs(+106 -85)📝
src/image/provider.rs(+21 -26)📄 Description
For symbolic icons to work with ironbar's
icon_theme, we need to adapt to GTK 4.20 changes.Required more refactoring than intended to
Also removed duplicate
feature = "clipboard",.Relevant:
https://docs.gtk.org/gtk4/migrating-3to4.html#adapt-to-gtkicontheme-api-changes
https://docs.gtk.org/gtk4/migrating-3to4.html#dont-use-gtk-icon-theme-in-your-css
Fixes: #1039
Given the scope, prolly makes sense for v0.19.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.