[PR #748] [MERGED] Workspaces module rewrite #2325

New issue

Closed

opened 2026-05-22 22:56:30 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 22:56:30 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/748
Author: @JakeStanger
Created: 10/18/2024
Status: ✅ Merged
Merged: 12/28/2024
Merged by: @JakeStanger

Base: master ← Head: fix/workspaces

📝 Commits (3)

8cdbe7e refactor(hyprland): improve logging
fa6f27d fix(workspaces): rewrite module to fix several small issues
03136e7 feat(workspaces): new sorting options

📊 Changes

9 files changed (+611 additions, -471 deletions)

View changed files

📝 docs/modules/Workspaces.md (+8 -8)
📝 src/clients/compositor/hyprland.rs (+2 -1)
📝 src/clients/compositor/mod.rs (+6 -10)
📝 src/gtk_helpers.rs (+1 -1)
➖ src/modules/workspaces.rs (+0 -451)
➕ src/modules/workspaces/button.rs (+78 -0)
➕ src/modules/workspaces/button_map.rs (+77 -0)
➕ src/modules/workspaces/mod.rs (+409 -0)
➕ src/modules/workspaces/open_state.rs (+30 -0)

📄 Description

fix(workspaces): rewrite module to fix several small issues

Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay!

Fixes #705

Fixes an issue with moving favourite workspaces.

Fixes an issue with workspace visible state being incorrect.

Fixes an issue where the inactive class looked at hidden instead of closed favourites.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/748 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 10/18/2024 **Status:** ✅ Merged **Merged:** 12/28/2024 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/workspaces` --- ### 📝 Commits (3) - [`8cdbe7e`](https://github.com/JakeStanger/ironbar/commit/8cdbe7e083325f41ffa565eaeb63d0841345c8a1) refactor(hyprland): improve logging - [`fa6f27d`](https://github.com/JakeStanger/ironbar/commit/fa6f27d4b9e4ef48d0d2dc3fa80b331b32a7c086) fix(workspaces): rewrite module to fix several small issues - [`03136e7`](https://github.com/JakeStanger/ironbar/commit/03136e7c700e545c566eb281c50e6ea343646bc6) feat(workspaces): new sorting options ### 📊 Changes **9 files changed** (+611 additions, -471 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/Workspaces.md` (+8 -8) 📝 `src/clients/compositor/hyprland.rs` (+2 -1) 📝 `src/clients/compositor/mod.rs` (+6 -10) 📝 `src/gtk_helpers.rs` (+1 -1) ➖ `src/modules/workspaces.rs` (+0 -451) ➕ `src/modules/workspaces/button.rs` (+78 -0) ➕ `src/modules/workspaces/button_map.rs` (+77 -0) ➕ `src/modules/workspaces/mod.rs` (+409 -0) ➕ `src/modules/workspaces/open_state.rs` (+30 -0) </details> ### 📄 Description fix(workspaces): rewrite module to fix several small issues Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay! Fixes #705 Fixes an issue with moving favourite workspaces. Fixes an issue with workspace visible state being incorrect. Fixes an issue where the `inactive` class looked at hidden instead of closed favourites. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 22:56:30 +01:00