[PR #530] [MERGED] feat: Add orientation support for clock, button, label, and sys_info #2189

New issue

Closed

opened 2026-05-22 22:56:06 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 22:56:06 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/530
Author: @ClaireNeveu
Created: 4/4/2024
Status: ✅ Merged
Merged: 4/6/2024
Merged by: @JakeStanger

Base: master ← Head: master

📝 Commits (5)

702b0a6 feat: Add orientation support for clock
70b2c59 feat: Add orientation support for custom label and button
44be585 feat: Add orientation and direction support for sys info
dcb5036 chore: add test config file
f50a65e fix: upower module should display correctly for vertical bars

📊 Changes

15 files changed (+272 additions, -40 deletions)

View changed files

📝 docs/modules/Clock.md (+1 -0)
📝 docs/modules/Custom.md (+2 -0)
📝 docs/modules/Sys-Info.md (+2 -0)
📝 src/config/common.rs (+28 -0)
📝 src/config/mod.rs (+1 -1)
📝 src/modules/clock.rs (+6 -2)
📝 src/modules/custom/box.rs (+4 -6)
📝 src/modules/custom/button.rs (+6 -0)
📝 src/modules/custom/label.rs (+5 -0)
📝 src/modules/custom/mod.rs (+1 -12)
📝 src/modules/custom/progress.rs (+5 -7)
📝 src/modules/custom/slider.rs (+5 -7)
📝 src/modules/sysinfo.rs (+14 -4)
📝 src/modules/upower.rs (+0 -1)
➕ test-configs/orientation.corn (+192 -0)

📄 Description

After making the switch to hyprland ironbar is by far the best dock solution I've found. Most wayland dockbars that aren't built into a big DE have very poor support for vertical docks or lack a proper program list/launcher. The one big issue I've run into is that the clock is incorrectly rotated when using a vertical bar. In this discussion you mentioned you wanted to keep the current behavior as an option.

I went ahead and added orientation support for clock as well as label and button which some people were asking for. I also created an enum for orientation and moved deserialization into serde and out of an ad-hoc function.

I also added a test config where you can see that all variations (default, horizontal, and vertical along with shorthand) are functioning properly.

Please let me know if there's anything you need on my end to get this merged, I didn't see any contribution guidelines or standards in the repo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/530 **Author:** [@ClaireNeveu](https://github.com/ClaireNeveu) **Created:** 4/4/2024 **Status:** ✅ Merged **Merged:** 4/6/2024 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`702b0a6`](https://github.com/JakeStanger/ironbar/commit/702b0a63bf75204d03f9229f1667cb2e77c1b8b8) feat: Add orientation support for clock - [`70b2c59`](https://github.com/JakeStanger/ironbar/commit/70b2c592b284965382182098b0b90b40bdac9965) feat: Add orientation support for custom label and button - [`44be585`](https://github.com/JakeStanger/ironbar/commit/44be58594b296ff6a1a7d902c88aa01116322538) feat: Add orientation and direction support for sys info - [`dcb5036`](https://github.com/JakeStanger/ironbar/commit/dcb5036964524d59a56263e52135574fd7af8459) chore: add test config file - [`f50a65e`](https://github.com/JakeStanger/ironbar/commit/f50a65eab5edfa3a96e4e3b7e54de754ead1eb21) fix: upower module should display correctly for vertical bars ### 📊 Changes **15 files changed** (+272 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/Clock.md` (+1 -0) 📝 `docs/modules/Custom.md` (+2 -0) 📝 `docs/modules/Sys-Info.md` (+2 -0) 📝 `src/config/common.rs` (+28 -0) 📝 `src/config/mod.rs` (+1 -1) 📝 `src/modules/clock.rs` (+6 -2) 📝 `src/modules/custom/box.rs` (+4 -6) 📝 `src/modules/custom/button.rs` (+6 -0) 📝 `src/modules/custom/label.rs` (+5 -0) 📝 `src/modules/custom/mod.rs` (+1 -12) 📝 `src/modules/custom/progress.rs` (+5 -7) 📝 `src/modules/custom/slider.rs` (+5 -7) 📝 `src/modules/sysinfo.rs` (+14 -4) 📝 `src/modules/upower.rs` (+0 -1) ➕ `test-configs/orientation.corn` (+192 -0) </details> ### 📄 Description After making the switch to hyprland ironbar is by far the best dock solution I've found. Most wayland dockbars that aren't built into a big DE have very poor support for vertical docks _or_ lack a proper program list/launcher. The one big issue I've run into is that the clock is incorrectly rotated when using a vertical bar. In [this discussion](https://github.com/JakeStanger/ironbar/discussions/294) you mentioned you wanted to keep the current behavior as an option. I went ahead and added orientation support for clock as well as label and button which some people were asking for. I also created an enum for orientation and moved deserialization into serde and out of an ad-hoc function. I also added a test config where you can see that all variations (default, horizontal, and vertical along with shorthand) are functioning properly. Please let me know if there's anything you need on my end to get this merged, I didn't see any contribution guidelines or standards in the repo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 22:56:06 +01:00