[PR #477] Added support for getting the cover art from mpd #2152

New issue

Open

opened 2026-05-22 22:55:59 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 22:55:59 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/477
Author: @eternalfrustation
Created: 2/27/2024
Status: 🔄 Open

Base: master ← Head: album_art_from_file

📝 Commits (10+)

666188e Added support for using a cover image which has a specific static path in the music module
5fe8e54 Added support for using kbps, kBps for total network usage
d7d0042 Added support for getting the cover art from mpd
4505cb5 Satisfying Clippy
9f19b54 feat: Modifying the image via message passing
6152483 fix: Removed the path section from Cargo.toml
30113fb fix: Ran cargo update
5a68847 fix: Removed the image crate from dependencies
b527ae7 fix: Moved the Cacellable and MemoryStream imports out of the cfg_if block
a5eb6f3 fix: Only sending the GetAlbumArt signal when needed

📊 Changes

10 files changed (+316 additions, -4252 deletions)

View changed files

➖ Cargo.lock (+0 -4103)
📝 Cargo.toml (+2 -1)
📝 src/clients/music/mod.rs (+4 -0)
📝 src/clients/music/mpd.rs (+116 -27)
📝 src/clients/music/mpris.rs (+9 -0)
📝 src/image/provider.rs (+25 -20)
📝 src/modules/mod.rs (+0 -1)
📝 src/modules/music/config.rs (+4 -2)
📝 src/modules/music/mod.rs (+119 -95)
📝 src/modules/sysinfo.rs (+37 -3)

📄 Description

As proposed in the previous PR (#466), this PR implements displaying cover art from mpd using the readpicture command

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/477 **Author:** [@eternalfrustation](https://github.com/eternalfrustation) **Created:** 2/27/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `album_art_from_file` --- ### 📝 Commits (10+) - [`666188e`](https://github.com/JakeStanger/ironbar/commit/666188eb6b48e90df81fb5ad7f77aad08e1533a6) Added support for using a cover image which has a specific static path in the music module - [`5fe8e54`](https://github.com/JakeStanger/ironbar/commit/5fe8e543f8b5aaa7885aa21aa8ae9554cffdd5f2) Added support for using kbps, kBps for total network usage - [`d7d0042`](https://github.com/JakeStanger/ironbar/commit/d7d004297a46a8cb62bd52710bb4ed9c6b4d043e) Added support for getting the cover art from mpd - [`4505cb5`](https://github.com/JakeStanger/ironbar/commit/4505cb55062bd466eb9359a10e768cbc045d01ab) Satisfying Clippy - [`9f19b54`](https://github.com/JakeStanger/ironbar/commit/9f19b54ea6ea59be1f4bbc04240503af42907789) feat: Modifying the image via message passing - [`6152483`](https://github.com/JakeStanger/ironbar/commit/61524836005484cb00cd61313a08e886e3b3ce61) fix: Removed the path section from Cargo.toml - [`30113fb`](https://github.com/JakeStanger/ironbar/commit/30113fbcb742c2d390601ddbefad633bdada0910) fix: Ran cargo update - [`5a68847`](https://github.com/JakeStanger/ironbar/commit/5a68847e2c2197db8058d4bc39a02bfb2a20208b) fix: Removed the image crate from dependencies - [`b527ae7`](https://github.com/JakeStanger/ironbar/commit/b527ae7a610ed120c2ceee4b84fcdc4354979e7c) fix: Moved the Cacellable and MemoryStream imports out of the cfg_if block - [`a5eb6f3`](https://github.com/JakeStanger/ironbar/commit/a5eb6f390f43811e9e5f4f24839f20c2dbca3160) fix: Only sending the GetAlbumArt signal when needed ### 📊 Changes **10 files changed** (+316 additions, -4252 deletions) <details> <summary>View changed files</summary> ➖ `Cargo.lock` (+0 -4103) 📝 `Cargo.toml` (+2 -1) 📝 `src/clients/music/mod.rs` (+4 -0) 📝 `src/clients/music/mpd.rs` (+116 -27) 📝 `src/clients/music/mpris.rs` (+9 -0) 📝 `src/image/provider.rs` (+25 -20) 📝 `src/modules/mod.rs` (+0 -1) 📝 `src/modules/music/config.rs` (+4 -2) 📝 `src/modules/music/mod.rs` (+119 -95) 📝 `src/modules/sysinfo.rs` (+37 -3) </details> ### 📄 Description As proposed in the previous PR (#466), this PR implements displaying cover art from mpd using the readpicture command --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger added the

pull-request

label

2026-05-22 22:55:59 +01:00