[PR #391] [MERGED] Workspace Issues Fixes #2089

New issue

Closed

opened 2026-05-22 22:55:49 +01:00 by JakeStanger · 0 comments

JakeStanger commented

2026-05-22 22:55:49 +01:00

Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/391
Author: @JakeStanger
Created: 12/31/2023
Status: ✅ Merged
Merged: 12/31/2023
Merged by: @JakeStanger

Base: master ← Head: fix/workspace-issues

📝 Commits (5)

c356b22 fix(workspaces): favourites missing inactive class on startup
1b54de9 build(deps): update glib
967801d refactor(workspaces): avoid sending unknown update info
b2a37a3 refactor: fix clippy warning
b4d7545 fix(regression): GTK refactor causing updates to be missed

📊 Changes

21 files changed (+50 additions, -35 deletions)

View changed files

📝 Cargo.lock (+2 -2)
📝 Cargo.toml (+1 -1)
📝 src/clients/compositor/hyprland.rs (+0 -1)
📝 src/clients/compositor/mod.rs (+5 -1)
📝 src/clients/compositor/sway.rs (+6 -3)
📝 src/config/mod.rs (+1 -1)
📝 src/dynamic_value/dynamic_bool.rs (+1 -1)
📝 src/dynamic_value/dynamic_string.rs (+1 -1)
📝 src/image/provider.rs (+1 -1)
📝 src/ipc/server.rs (+1 -1)
📝 src/macros.rs (+10 -6)
📝 src/modules/clipboard.rs (+1 -1)
📝 src/modules/clock.rs (+2 -2)
📝 src/modules/custom/progress.rs (+1 -1)
📝 src/modules/custom/slider.rs (+1 -1)
📝 src/modules/launcher/mod.rs (+2 -2)
📝 src/modules/mod.rs (+1 -1)
📝 src/modules/music/mod.rs (+2 -2)
📝 src/modules/upower.rs (+2 -2)
📝 src/modules/workspaces.rs (+8 -3)

...and 1 more files

📄 Description

Important commits:

fix(regression): GTK refactor causing updates to be missed

Regression introduced by recent GTK refactor.

The glib_recv macros previously using the passed in expression as the receiver, which was causing a new receiver to be created every time an event was received. This caused some peculiar behaviours where some events just never got through if sent too close to each other.

This was most obvious in the workspaces module.

Fixes #381

fix(workspaces): favourites missing inactive class on startup

Fixes #390

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/391 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 12/31/2023 **Status:** ✅ Merged **Merged:** 12/31/2023 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `fix/workspace-issues` --- ### 📝 Commits (5) - [`c356b22`](https://github.com/JakeStanger/ironbar/commit/c356b22401ad412c9a6a7f0092f2f2214e13f5f0) fix(workspaces): favourites missing `inactive` class on startup - [`1b54de9`](https://github.com/JakeStanger/ironbar/commit/1b54de98e676d93a8e8ff968b10c9b2d113de016) build(deps): update glib - [`967801d`](https://github.com/JakeStanger/ironbar/commit/967801dc322c8edbc5335e4e23d70a2442b5280c) refactor(workspaces): avoid sending unknown update info - [`b2a37a3`](https://github.com/JakeStanger/ironbar/commit/b2a37a32b07d46fe56cb7c6b81b9e7da3fe27a15) refactor: fix clippy warning - [`b4d7545`](https://github.com/JakeStanger/ironbar/commit/b4d75450acacc36a71e0ed8365f82bd88d2a55e8) fix(regression): GTK refactor causing updates to be missed ### 📊 Changes **21 files changed** (+50 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+2 -2) 📝 `Cargo.toml` (+1 -1) 📝 `src/clients/compositor/hyprland.rs` (+0 -1) 📝 `src/clients/compositor/mod.rs` (+5 -1) 📝 `src/clients/compositor/sway.rs` (+6 -3) 📝 `src/config/mod.rs` (+1 -1) 📝 `src/dynamic_value/dynamic_bool.rs` (+1 -1) 📝 `src/dynamic_value/dynamic_string.rs` (+1 -1) 📝 `src/image/provider.rs` (+1 -1) 📝 `src/ipc/server.rs` (+1 -1) 📝 `src/macros.rs` (+10 -6) 📝 `src/modules/clipboard.rs` (+1 -1) 📝 `src/modules/clock.rs` (+2 -2) 📝 `src/modules/custom/progress.rs` (+1 -1) 📝 `src/modules/custom/slider.rs` (+1 -1) 📝 `src/modules/launcher/mod.rs` (+2 -2) 📝 `src/modules/mod.rs` (+1 -1) 📝 `src/modules/music/mod.rs` (+2 -2) 📝 `src/modules/upower.rs` (+2 -2) 📝 `src/modules/workspaces.rs` (+8 -3) _...and 1 more files_ </details> ### 📄 Description Important commits: **fix(regression): GTK refactor causing updates to be missed** Regression introduced by recent GTK refactor. The `glib_recv` macros previously using the passed in expression as the receiver, which was causing a new receiver to be created *every* time an event was received. This caused some peculiar behaviours where some events just never got through if sent too close to each other. This was most obvious in the `workspaces` module. Fixes #381 **fix(workspaces): favourites missing `inactive` class on startup** Fixes #390 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

JakeStanger

2026-05-22 22:55:49 +01:00