[PR #106] [MERGED] Custom image dynamic src support #1897

Closed
opened 2026-05-22 22:55:14 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/106
Author: @JakeStanger
Created: 4/10/2023
Status: Merged
Merged: 4/10/2023
Merged by: @JakeStanger

Base: masterHead: feat/custom-dynamic-image


📝 Commits (4)

  • 3d308ab feat(custom): support dynamic string in image source
  • c214f65 refactor: fix strict clippy warnings
  • 7355db7 fix(image): http provider not handling non-success codes
  • 138b5b3 docs(custom): fix potential error in progress example

📊 Changes

6 files changed (+47 additions, -36 deletions)

View changed files

📝 docs/modules/Custom.md (+5 -5)
📝 src/image/provider.rs (+11 -2)
📝 src/modules/custom/box.rs (+1 -1)
📝 src/modules/custom/image.rs (+22 -9)
📝 src/modules/custom/mod.rs (+7 -7)
📝 src/modules/custom/slider.rs (+1 -12)

📄 Description

Resolves #94.

Also includes some general refactoring/fixes.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/106 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 4/10/2023 **Status:** ✅ Merged **Merged:** 4/10/2023 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `feat/custom-dynamic-image` --- ### 📝 Commits (4) - [`3d308ab`](https://github.com/JakeStanger/ironbar/commit/3d308ab572a39ada2501ddc1b822e50e1f8a8363) feat(custom): support dynamic string in image source - [`c214f65`](https://github.com/JakeStanger/ironbar/commit/c214f65ecb86a0da6559025203701661924f65bb) refactor: fix strict clippy warnings - [`7355db7`](https://github.com/JakeStanger/ironbar/commit/7355db74ec9118c2cb46899534a3adac8d7165d9) fix(image): http provider not handling non-success codes - [`138b5b3`](https://github.com/JakeStanger/ironbar/commit/138b5b39038a005d17069830a04b88d52730bed5) docs(custom): fix potential error in progress example ### 📊 Changes **6 files changed** (+47 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/Custom.md` (+5 -5) 📝 `src/image/provider.rs` (+11 -2) 📝 `src/modules/custom/box.rs` (+1 -1) 📝 `src/modules/custom/image.rs` (+22 -9) 📝 `src/modules/custom/mod.rs` (+7 -7) 📝 `src/modules/custom/slider.rs` (+1 -12) </details> ### 📄 Description Resolves #94. Also includes some general refactoring/fixes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-22 22:55:14 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#1897
No description provided.