mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 10:15:20 +01:00
[GH-ISSUE #639] [Workspaces] Workspaces renamed with name_map incorrectly being shown as active #1620
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#1620
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @michaelBelsanti on GitHub (Jun 10, 2024).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/639
Describe the bug
I am using this configuration:
I have workspaces 11-19 assigned to my second monitor. There is a bug occurring where whichever workspace is currently focused, is shown as the active workspace for both monitors. Eg. if I am on workspace 1 on my main monitor, the bar on my other monitor will also show workspace 1 as active, even though this workspace is actually 11 being renamed to 1. It seems that when a workspace is renamed using name_map, it is being treated the same as the original workspace.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The 1st workspace on my second monitor should not be shown as active.
System information:
Configuration
Screenshots

Both workspaces being active. Right monitor is primary, left is secondary. Left monitor is actually on workspace 2, but workspace 1 is being focused on the right monitor, so the bar is showing it as active for both.
@JakeStanger commented on GitHub (Aug 11, 2024):
Thanks for reporting & apologies for the delay. I thought this was going to be a nasty one but a nice easy fix. I'll merge in a few mins and the fix will be in -git
@michaelBelsanti commented on GitHub (Aug 11, 2024):
glad it was so simple. I assumed the same thing when I made this bug haha. turns out it was simpler to fix than it was to explain the bug lmao