[PR #1010] [MERGED] refactor: recv_glib dependency arrays #1092

Closed
opened 2026-05-22 21:55:33 +01:00 by JakeStanger · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/JakeStanger/ironbar/pull/1010
Author: @JakeStanger
Created: 5/26/2025
Status: Merged
Merged: 5/26/2025
Merged by: @JakeStanger

Base: masterHead: refactor/glib-deps


📝 Commits (1)

  • 9d18ce5 refactor: recv_glib dependency arrays

📊 Changes

31 files changed (+524 additions, -502 deletions)

View changed files

📝 src/channels.rs (+91 -16)
📝 src/config/common.rs (+8 -13)
📝 src/dynamic_value/dynamic_bool.rs (+6 -4)
📝 src/dynamic_value/dynamic_string.rs (+6 -4)
📝 src/ipc/server/mod.rs (+1 -2)
📝 src/modules/bindmode.rs (+11 -17)
📝 src/modules/cairo.rs (+1 -1)
📝 src/modules/clipboard.rs (+5 -6)
📝 src/modules/clock.rs (+2 -2)
📝 src/modules/custom/button.rs (+1 -1)
📝 src/modules/custom/image.rs (+7 -11)
📝 src/modules/custom/label.rs (+3 -6)
📝 src/modules/custom/progress.rs (+2 -3)
📝 src/modules/custom/slider.rs (+1 -1)
📝 src/modules/focused.rs (+1 -1)
📝 src/modules/keyboard.rs (+33 -29)
📝 src/modules/label.rs (+4 -8)
📝 src/modules/launcher/mod.rs (+86 -91)
📝 src/modules/menu/mod.rs (+18 -18)
📝 src/modules/mod.rs (+2 -4)

...and 11 more files

📄 Description

Adds a dependency array system to recv_glib which internally clones the passed deps and then passes by reference to the callback.

This cleans up a lot of the big {} blocks full of widget.clone() and removes a lot of boilerplate. Yay!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JakeStanger/ironbar/pull/1010 **Author:** [@JakeStanger](https://github.com/JakeStanger) **Created:** 5/26/2025 **Status:** ✅ Merged **Merged:** 5/26/2025 **Merged by:** [@JakeStanger](https://github.com/JakeStanger) **Base:** `master` ← **Head:** `refactor/glib-deps` --- ### 📝 Commits (1) - [`9d18ce5`](https://github.com/JakeStanger/ironbar/commit/9d18ce52f5a5076ce94ea6642bf0d8220d552d6c) refactor: `recv_glib` dependency arrays ### 📊 Changes **31 files changed** (+524 additions, -502 deletions) <details> <summary>View changed files</summary> 📝 `src/channels.rs` (+91 -16) 📝 `src/config/common.rs` (+8 -13) 📝 `src/dynamic_value/dynamic_bool.rs` (+6 -4) 📝 `src/dynamic_value/dynamic_string.rs` (+6 -4) 📝 `src/ipc/server/mod.rs` (+1 -2) 📝 `src/modules/bindmode.rs` (+11 -17) 📝 `src/modules/cairo.rs` (+1 -1) 📝 `src/modules/clipboard.rs` (+5 -6) 📝 `src/modules/clock.rs` (+2 -2) 📝 `src/modules/custom/button.rs` (+1 -1) 📝 `src/modules/custom/image.rs` (+7 -11) 📝 `src/modules/custom/label.rs` (+3 -6) 📝 `src/modules/custom/progress.rs` (+2 -3) 📝 `src/modules/custom/slider.rs` (+1 -1) 📝 `src/modules/focused.rs` (+1 -1) 📝 `src/modules/keyboard.rs` (+33 -29) 📝 `src/modules/label.rs` (+4 -8) 📝 `src/modules/launcher/mod.rs` (+86 -91) 📝 `src/modules/menu/mod.rs` (+18 -18) 📝 `src/modules/mod.rs` (+2 -4) _...and 11 more files_ </details> ### 📄 Description Adds a dependency array system to `recv_glib` which internally clones the passed deps and then passes by reference to the callback. This cleans up a lot of the big `{}` blocks full of `widget.clone()` and removes a lot of boilerplate. Yay! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
JakeStanger 2026-05-22 21:55:33 +01:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
JakeStanger/ironbar#1092
No description provided.