mirror of
https://github.com/JakeStanger/ironbar.git
synced 2026-07-11 12:15:22 +01:00
[GH-ISSUE #228] [Launcher] Incorrect icons being used #102
Labels
No labels
A:Build
A:CI
A:Client
A:Config
A:Core
A:Documentation
A:Documentation
A:IPC
A:Testing
A:UX/UI
blocked
BREAKING CHANGE
duplicate
good first issue
GTK4
help wanted
invalid
M:Battery
M:Battery
M:Bindmode
M:Bluetooth
M:Brightness
M:Cairo
M:Clipboard
M:Clock
M:Clock
M:Custom
M:Focused
M:Keyboard
M:Launcher
M:Menu
M:Music
M:Music
M:Music
M:Network Manager
M:Notifications
M:SysInfo
M:Tray
M:Volume
M:Workspaces
partially resolved
P:Critical
P:High
P:Low
P:Medium
pull-request
T:Bug
T:Bug
T:Core Enhancement
T:Module Enhancement
T:New Module
T:Question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/ironbar#102
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @donovanglover on GitHub (Jul 6, 2023).
Original GitHub issue: https://github.com/JakeStanger/ironbar/issues/228
Describe the bug
For example, if I add an
a.b.cfavorite I get a librewolf icon. Memento uses an htop icon, which I assume is because the class name isprojects.ripose.. Any programs that have the class name.program-wrappedappear to be broken as well.To Reproduce
mementoor use a random string of characters as a favoriteExpected behavior
Incorrect icons should never be visible to the user. How about an icon indicating that none was found instead?
System information:
github.com/JakeStanger/ironbar@abf490b04eAdditional context
The
memento.desktopfile has anIcon=mementofield. How feasible is it to use this instead of the app_id?Would it be better to let users specify their own class name and icon overrides? Should these overrides be mapped to desktop files?
@JakeStanger commented on GitHub (Jul 6, 2023):
Before the desktop file is consulted, the theme is checked for an icon name matching. If one isn't found, a search is done for desktop files, and it will check the
Iconfield. I suspect filenames are currently matching a bit too eagerly, and I'll need to tone this down to resolve this.