[GH-ISSUE #8] KeyError when album is not specified #7

New issue

Closed

opened 2026-05-22 22:02:30 +01:00 by JakeStanger · 5 comments

JakeStanger commented

2026-05-22 22:02:30 +01:00

Owner

Originally created by @EgZvor on GitHub (Oct 5, 2018).
Original GitHub issue: https://github.com/JakeStanger/Rofi_MPD/issues/8

Traceback (most recent call last):
  File "main.py", line 270, in <module>
    select_artist(selection_list)
  File "main.py", line 217, in select_artist
    select(title or 'All Artists', [*data])
  File "main.py", line 188, in select
    select_album(selection_list, selected_data)
  File "main.py", line 223, in select_album
    select(artist or 'All Albums', data, full_album=full_album)
  File "main.py", line 191, in select
    select_track(selection_list, selected_data['artist'], selected_data['album'])
  File "main.py", line 231, in select_track
    data = sorted([*data],
  File "main.py", line 229, in <lambda>
    and (x['data']['album'] == album if album else True), data)
KeyError: 'album'

Originally created by @EgZvor on GitHub (Oct 5, 2018). Original GitHub issue: https://github.com/JakeStanger/Rofi_MPD/issues/8 ``` Traceback (most recent call last): File "main.py", line 270, in <module> select_artist(selection_list) File "main.py", line 217, in select_artist select(title or 'All Artists', [*data]) File "main.py", line 188, in select select_album(selection_list, selected_data) File "main.py", line 223, in select_album select(artist or 'All Albums', data, full_album=full_album) File "main.py", line 191, in select select_track(selection_list, selected_data['artist'], selected_data['album']) File "main.py", line 231, in select_track data = sorted([*data], File "main.py", line 229, in <lambda> and (x['data']['album'] == album if album else True), data) KeyError: 'album' ```

JakeStanger

2026-05-22 22:02:30 +01:00

closed this issue
added the
bug
label

JakeStanger commented

2026-05-22 22:02:31 +01:00

Author

Owner

@JakeStanger commented on GitHub (Oct 5, 2018):

Hi, could you give me the data causing this to fail please? I'm struggling to see why this would happen from just the code/error.

@JakeStanger commented on GitHub (Oct 5, 2018): Hi, could you give me the data causing this to fail please? I'm struggling to see why this would happen from just the code/error.

JakeStanger commented

2026-05-22 22:02:31 +01:00

Author

Owner

@EgZvor commented on GitHub (Oct 6, 2018):

➜ ~/Music id3 Wallace\ Collection\ -\ Daydream.mp3 
File: Wallace Collection - Daydream.mp3
Metadata: ID3v2.3
Title: Daydream
Artist: Wallace Collection

@EgZvor commented on GitHub (Oct 6, 2018): ``` ➜ ~/Music id3 Wallace\ Collection\ -\ Daydream.mp3 File: Wallace Collection - Daydream.mp3 Metadata: ID3v2.3 Title: Daydream Artist: Wallace Collection ```

JakeStanger commented

2026-05-22 22:02:31 +01:00

Author

Owner

@EgZvor commented on GitHub (Oct 6, 2018):

You can delete tags with id3 --delete <filename>

@EgZvor commented on GitHub (Oct 6, 2018): You can delete tags with `id3 --delete <filename>`

JakeStanger commented

2026-05-22 22:02:31 +01:00

Author

Owner

@EgZvor commented on GitHub (Oct 6, 2018):

I think it's because of this.

            # Handle songs with missing album tag
            if 'album' in song:
                album = song['album']
            else:
                album = "[Unknown Album]"

[Unknown Album] is then used as a value, an the check if album doesn't apply.

@EgZvor commented on GitHub (Oct 6, 2018): I think it's because of this. ``` # Handle songs with missing album tag if 'album' in song: album = song['album'] else: album = "[Unknown Album]" ``` `[Unknown Album]` is then used as a value, an the check `if album` doesn't apply.

JakeStanger commented

2026-05-22 22:02:31 +01:00

Author

Owner

@JakeStanger commented on GitHub (Oct 7, 2018):

Yep, it was exactly that! It should be fixed now.

@JakeStanger commented on GitHub (Oct 7, 2018): Yep, it was exactly that! It should be fixed now.

JakeStanger referenced this issue

2026-05-22 22:50:10 +01:00

[GH-ISSUE #7] Date can be a list #5