mirror of
https://github.com/JakeStanger/Rofi_MPD.git
synced 2026-07-11 13:14:38 +01:00
[GH-ISSUE #17] More options for playing songs? #12
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
JakeStanger/Rofi_MPD#12
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @thepenguinthatwants on GitHub (Mar 31, 2020).
Original GitHub issue: https://github.com/JakeStanger/Rofi_MPD/issues/17
Hiya!
This plugin seems to work after adding some mediainfo to files.
Is it possible to add different options for better controls?
Like playing the song straight after choosing it?
@JakeStanger commented on GitHub (Mar 31, 2020):
Good to hear! Do you know which tags were missing, out of interest? I'll try and make things fail more gracefully if it's something silly.
I can definitely add a setting to start playback on add. Do you have anything else in mind?
@thepenguinthatwants commented on GitHub (Apr 1, 2020):
Hi!
Thanks for the reply.
Practically all the media tags.
I thought that this could work based on file names. But using easytag it was quite easy to tag all of em. I always thought that the title is same than file name.
Playback on add is like very good improvement already.
Maybe also possibility to change playlists on the fly? That would make it even crazier.
Normally would've thought about next and previous tracks but they are good enough to be as normal keybindings.
@JakeStanger commented on GitHub (Apr 1, 2020):
Right yeah, you need your tracks to be tagged for MPD to work; filenames mean nothing.
Getting a list of playlists from the playlist directory should be quite straight-forward. I'll see what I can do.
@JakeStanger commented on GitHub (Apr 1, 2020):
@thepenguinthatwants I've just pushed a new release and updated the PyPi package to
2.1.0.Try adding
play_on_add = trueto your config and using the--playlistsargument. If both work I'll close this 👍@thepenguinthatwants commented on GitHub (Apr 2, 2020):
I downloaded r80.76cc551-1 version from
https://aur.archlinux.org/packages/rofi-mpd-git/
Added play_on_add = true to the mpd.conf but adding a song didnt start plaiying it.
@thepenguinthatwants commented on GitHub (Apr 2, 2020):
The playlist seems to work!
Cool!!! You are awesome!
@JakeStanger commented on GitHub (Apr 2, 2020):
The option goes in the config for this app, not your MPD config.
MPD is a server that has no awareness of this app, and it's this app that tells the player to start playback.
Config file is documented in the readme.
@thepenguinthatwants commented on GitHub (Apr 2, 2020):
Oh how foolish of me sorry.
I added it to my configs but it didnt change. Adding a song to the list didnt start the song.
@thepenguinthatwants commented on GitHub (Apr 2, 2020):
It does start plaiying the music player.. but only the song that is first on the list.. not the song that this script added.
@JakeStanger commented on GitHub (Apr 2, 2020):
The script only changes the player state from stopped/paused to playing, it doesn't update the index.
Personally if I was queuing songs into a playlist, I'd rather playback started from the top of the playlist rather than where I just added songs, so this behavior makes sense to me.
This app isn't meant to be a full client so I want to be quite careful about adding more features. What I will do is make the
play_on_addoption a CLI flag as well, so you can override your config on a run-by-run basis.I'll add this in a couple of hours and let you know when it's done.
@JakeStanger commented on GitHub (Apr 5, 2020):
Sorry it took me a little longer than expected, ended up being busy the past few days.
I've added two new CLI options -
--playand--noplaywhich will override the config'splay_on_addvalue on a per-run basis.@JakeStanger commented on GitHub (Apr 15, 2020):
Closing this, feel free to re-open it or open another issue.